From: Masami Hiramatsu <mhiramat@kernel.org>
To: rostedt@goodmis.org,
Francis Deslauriers <francis.deslauriers@efficios.com>,
peterz@infradead.org, Shuah Khan <shuah@kernel.org>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/3] tracing: kprobes: Prohibit probing on notrace functions
Date: Mon, 30 Jul 2018 19:19:45 +0900 [thread overview]
Message-ID: <153294598465.32740.17737878083872427008.stgit@devbox> (raw)
Hi,
This is the 5th version of the series to prohibit kprobe
on notrace functions.
This fixes a build error when CONFIG_FUNCTION_TRACER=y but
DYNAMIC_FTRACE=n. Finally I decided to recover the approach
in the 1st version, made it depends on CONFIG_KPROBES_ON_FTRACE=y.
It is the simplest and enough to prohibiting kernel crash.
So, in summary, if CONFIG_KPROBES_ON_FTRACE=y (which depends
on CONFIG_DYNAMIC_FTRACE=y, so ftrace_location_range must be
there) && CONFIG_KPROBE_EVENTS_ON_NOTRACE=n (default),
kprobe events can not be defined on notrace function.
Otherwides (means CONFIG_KPROBES_ON_FTRACE=n or
CONFIG_KPROBE_EVENTS_ON_NOTRACE=y), we can put kprobe events
on notrace functions.
Francis, I dropped your tested-by because I got many kbuild
errors and fixed it. If you can, could you test it again?
Thank you,
---
Francis Deslauriers (1):
selftest/ftrace: Move kprobe selftest function to separate compile unit
Masami Hiramatsu (2):
tracing: kprobes: Prohibit probing on notrace function
selftests/ftrace: Fix kprobe string testcase to not probe notrace function
kernel/trace/Kconfig | 20 +++++++
kernel/trace/Makefile | 5 ++
kernel/trace/trace_kprobe.c | 59 +++++++++++++-------
kernel/trace/trace_kprobe_selftest.c | 10 +++
kernel/trace/trace_kprobe_selftest.h | 7 ++
.../ftrace/test.d/kprobe/kprobe_args_string.tc | 30 ++++------
.../selftests/ftrace/test.d/kprobe/probepoint.tc | 2 -
7 files changed, 94 insertions(+), 39 deletions(-)
create mode 100644 kernel/trace/trace_kprobe_selftest.c
create mode 100644 kernel/trace/trace_kprobe_selftest.h
--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
next reply other threads:[~2018-07-30 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 10:19 Masami Hiramatsu [this message]
2018-07-30 10:20 ` [PATCH v5 1/3] tracing: kprobes: Prohibit probing on notrace function Masami Hiramatsu
2018-07-30 22:40 ` Steven Rostedt
2018-07-31 1:04 ` Masami Hiramatsu
2018-07-30 10:20 ` [PATCH v5 2/3] selftest/ftrace: Move kprobe selftest function to separate compile unit Masami Hiramatsu
2018-07-30 10:21 ` [PATCH v5 3/3] selftests/ftrace: Fix kprobe string testcase to not probe notrace function Masami Hiramatsu
2018-07-30 16:06 ` [PATCH v5 0/3] tracing: kprobes: Prohibit probing on notrace functions Francis Deslauriers
2018-07-30 23:00 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153294598465.32740.17737878083872427008.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=francis.deslauriers@efficios.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome