From: zhong jiang <zhongjiang@huawei.com>
To: <tglx@linutronix.de>, <longman@redhat.com>
Cc: <arnd@arndb.de>, <yang.shi@linux.alibaba.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] lib/debugobjects: remove redundant check when free the object
Date: Wed, 1 Aug 2018 00:24:58 +0800 [thread overview]
Message-ID: <1533054298-35824-1-git-send-email-zhongjiang@huawei.com> (raw)
kmem_cache_destroy has taken the null check into account. so just
remove the unnecessary check.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
lib/debugobjects.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 994be48..7a6d80b 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -1185,8 +1185,7 @@ void __init debug_objects_mem_init(void)
if (!obj_cache || debug_objects_replace_static_objects()) {
debug_objects_enabled = 0;
- if (obj_cache)
- kmem_cache_destroy(obj_cache);
+ kmem_cache_destroy(obj_cache);
pr_warn("out of memory.\n");
} else
debug_objects_selftest();
--
1.7.12.4
next reply other threads:[~2018-07-31 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 16:24 zhong jiang [this message]
2018-08-02 11:57 ` [tip:core/debugobjects] debugobjects: Remove redundant NULL pointer check tip-bot for Zhong Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533054298-35824-1-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=tglx@linutronix.de \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®