From: Jheng-Jhong Wu <goodwater.wu@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: goodwater.wu@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages
Date: Wed, 1 Aug 2018 17:44:18 +0800 [thread overview]
Message-ID: <1533116658-14924-1-git-send-email-goodwater.wu@gmail.com> (raw)
In spinand_program_page(), it uses devm_kzalloc() to allocate memory to
wbuf dynamically if internal ECC is on, but it doesn't free memory
allocated to wbuf at the end of this function. This leads to a memory leak
issue when internal ECC is on.
Signed-off-by: Jheng-Jhong Wu <goodwater.wu@gmail.com>
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c
index e389009..cf51ca8 100644
--- a/drivers/staging/mt29f_spinand/mt29f_spinand.c
+++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c
@@ -553,6 +553,8 @@ static int spinand_program_page(struct spi_device *spi_nand,
}
enable_hw_ecc = 0;
}
+
+ devm_kfree(&spi_nand->dev, wbuf);
#endif
return 0;
--
2.7.4
next reply other threads:[~2018-08-01 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 9:44 Jheng-Jhong Wu [this message]
2018-08-01 11:45 ` Dan Carpenter
[not found] ` <CALtPoQCyoe5V0m5=3K1XeZm41aDCaJ0rmYU-a=qkm=Yb8jgMxg@mail.gmail.com>
2018-08-02 3:42 ` Jheng-Jhong Wu
2018-08-02 6:12 ` Dan Carpenter
2018-08-02 7:51 ` [PATCH v2] " Jheng-Jhong Wu
2018-08-02 8:02 ` Greg Kroah-Hartman
2018-08-02 8:31 ` Jheng-Jhong Wu
2018-08-02 8:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533116658-14924-1-git-send-email-goodwater.wu@gmail.com \
--to=goodwater.wu@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®