mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org
Cc: Steve Longerbeam <steve_longerbeam@mentor.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR
	FREESCALE IMX), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 04/14] gpu: ipu-v3: Fix U/V offset macros for planar 4:2:0
Date: Wed,  1 Aug 2018 12:12:17 -0700	[thread overview]
Message-ID: <1533150747-30677-5-git-send-email-steve_longerbeam@mentor.com> (raw)
In-Reply-To: <1533150747-30677-1-git-send-email-steve_longerbeam@mentor.com>

The U and V offset macros for planar 4:2:0 (U_OFFSET, V_OFFSET, and
UV_OFFSET), are not correct. The height component to the offset was
calculated as:

(pix->width * y / 4)

But this does not produce correct offsets for odd values of y (luma
line #). The luma line # must be decimated by two to produce the
correct U/V line #, so the correct formula is:

(pix->width * (y / 2) / 2)

Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
---
 drivers/gpu/ipu-v3/ipu-cpmem.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/ipu-v3/ipu-cpmem.c b/drivers/gpu/ipu-v3/ipu-cpmem.c
index 9f2d9ec..e68e473 100644
--- a/drivers/gpu/ipu-v3/ipu-cpmem.c
+++ b/drivers/gpu/ipu-v3/ipu-cpmem.c
@@ -530,17 +530,17 @@ static const struct ipu_rgb def_bgra_16 = {
 
 #define Y_OFFSET(pix, x, y)	((x) + pix->width * (y))
 #define U_OFFSET(pix, x, y)	((pix->width * pix->height) +		\
-				 (pix->width * (y) / 4) + (x) / 2)
+				 (pix->width * ((y) / 2) / 2) + (x) / 2)
 #define V_OFFSET(pix, x, y)	((pix->width * pix->height) +		\
 				 (pix->width * pix->height / 4) +	\
-				 (pix->width * (y) / 4) + (x) / 2)
+				 (pix->width * ((y) / 2) / 2) + (x) / 2)
 #define U2_OFFSET(pix, x, y)	((pix->width * pix->height) +		\
 				 (pix->width * (y) / 2) + (x) / 2)
 #define V2_OFFSET(pix, x, y)	((pix->width * pix->height) +		\
 				 (pix->width * pix->height / 2) +	\
 				 (pix->width * (y) / 2) + (x) / 2)
 #define UV_OFFSET(pix, x, y)	((pix->width * pix->height) +	\
-				 (pix->width * (y) / 2) + (x))
+				 (pix->width * ((y) / 2)) + (x))
 #define UV2_OFFSET(pix, x, y)	((pix->width * pix->height) +	\
 				 (pix->width * y) + (x))
 
-- 
2.7.4


  parent reply	other threads:[~2018-08-01 19:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1533150747-30677-1-git-send-email-steve_longerbeam@mentor.com>
2018-08-01 19:12 ` [PATCH v3 01/14] media: videodev2.h: Add more field helper macros Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 02/14] gpu: ipu-csi: Check for field type alternate Steve Longerbeam
2018-08-02  9:42   ` Philipp Zabel
2018-08-04 19:08     ` Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 03/14] gpu: ipu-csi: Swap fields according to input/output field types Steve Longerbeam
2018-08-01 19:12 ` Steve Longerbeam [this message]
2018-08-02  9:51   ` [PATCH v3 04/14] gpu: ipu-v3: Fix U/V offset macros for planar 4:2:0 Philipp Zabel
2018-08-01 19:12 ` [PATCH v3 05/14] gpu: ipu-v3: Allow negative offsets for interlaced scanning Steve Longerbeam
2018-08-02  9:46   ` Philipp Zabel
2018-08-04 19:25     ` Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 06/14] gpu: ipu-v3: Add planar support to interlaced scan Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 07/14] media: imx: Fix field negotiation Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 08/14] media: imx-csi: Double crop height for alternate fields at sink Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 09/14] media: imx: interweave and odd-chroma-row skip are incompatible Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 10/14] media: imx-csi: Allow skipping odd chroma rows for YVU420 Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 11/14] media: imx: vdic: rely on VDIC for correct field order Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 12/14] media: imx-csi: Move crop/compose reset after filling default mbus fields Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 13/14] media: imx: Allow interweave with top/bottom lines swapped Steve Longerbeam
2018-08-01 19:12 ` [PATCH v3 14/14] media: imx.rst: Update doc to reflect fixes to interlaced capture Steve Longerbeam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533150747-30677-5-git-send-email-steve_longerbeam@mentor.com \
    --to=slongerbeam@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=steve_longerbeam@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®