From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB15EC43142 for ; Thu, 2 Aug 2018 09:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3F0E214FB for ; Thu, 2 Aug 2018 09:52:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3F0E214FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731202AbeHBLmW (ORCPT ); Thu, 2 Aug 2018 07:42:22 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:51661 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbeHBLmW (ORCPT ); Thu, 2 Aug 2018 07:42:22 -0400 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1flAGy-0008TE-54; Thu, 02 Aug 2018 11:51:56 +0200 Message-ID: <1533203515.3516.13.camel@pengutronix.de> Subject: Re: [PATCH v3 04/14] gpu: ipu-v3: Fix U/V offset macros for planar 4:2:0 From: Philipp Zabel To: Steve Longerbeam , linux-media@vger.kernel.org Cc: Steve Longerbeam , "open list:DRM DRIVERS FOR FREESCALE IMX" , open list Date: Thu, 02 Aug 2018 11:51:55 +0200 In-Reply-To: <1533150747-30677-5-git-send-email-steve_longerbeam@mentor.com> References: <1533150747-30677-1-git-send-email-steve_longerbeam@mentor.com> <1533150747-30677-5-git-send-email-steve_longerbeam@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-08-01 at 12:12 -0700, Steve Longerbeam wrote: > The U and V offset macros for planar 4:2:0 (U_OFFSET, V_OFFSET, and > UV_OFFSET), are not correct. The height component to the offset was > calculated as: > > (pix->width * y / 4) > > But this does not produce correct offsets for odd values of y (luma > line #). The luma line # must be decimated by two to produce the > correct U/V line #, so the correct formula is: > > (pix->width * (y / 2) / 2) > > Signed-off-by: Steve Longerbeam Thank you this patch is applied to imx-drm/fixes now. regards Philipp