From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751192AbdCQMAK (ORCPT ); Fri, 17 Mar 2017 08:00:10 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:50989 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110AbdCQMAE (ORCPT ); Fri, 17 Mar 2017 08:00:04 -0400 X-AuditID: b6c32a2d-f793d6d0000012b6-0e-58cbcfbfc4a0 From: Bartlomiej Zolnierkiewicz To: Tejun Heo Cc: Russell King , Sergei Shtylyov , Sekhar Nori , Arnd Bergmann , Dmitry Eremin-Solenikov , Kevin Hilman , Olof Johansson , linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_pcmcia: add EBSA110's PCMCIA slot support Date: Fri, 17 Mar 2017 12:59:56 +0100 Message-id: <1533391.BtkrkgvqUW@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170316212654.GD1480@htj.duckdns.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDKsWRmVeSWpSXmKPExsWy7bCmpu7+86cjDA7fM7H4O+kYu8WkJ++Z LX62b2Gy2PT4GqvFsR2PmCwu75rDZrG/dwOTxanrn9ksLvVPZLI4s+oWu8Wv5UcZHbg9Ll+7 yOzx+9ckRo/3N1rZPR5M/c/ksXPWXXaPTas62Tw2L6n3uHKiidXj+I3tTB6fN8kFcEVx2aSk 5mSWpRbp2yVwZSzf/oytYDVPxdk78g2MLzm7GDk5JARMJO5N3sEIYYtJXLi3nq2LkYtDSGAp o8SaxY1QTjuTxO3Oa8wwHdOuTWYDsYUE5jBK3NjjBlH0lVHi66FeVpAEm4CVxMT2VWBjRQRk Ja5Me8gIUsQs8J9JYt3eW2DdwgLOEpcvPWPpYuTgYBFQlTh3URgkzCugKbHz3QGwZaICXhJb 9rUzgdicQIsvnvzHBlEjKPFj8j0WEJtZQF5i3/6prBC2jsTZY+vAdkkIvGSX2NO8hR1kvgTQ EZsOQD3gIvHx1CJWCFtY4tVxkBIQW1ri79Jb0KCYziix/bcExJzNjBKrdk+AKrKWOHz8ItQy Pone30+YIObzSnS0CUGUeEjsffUdqtxRYspRkHs4IEG6S2YCo/wsJB/MQvLBLCQfLGBkXsUo llpQnJueWmxaYKRXnJhbXJqXrpecn7uJEZymtHR3MH5Z4H2IUYCDUYmHV6L9dIQQa2JZcWXu IUYJDmYlEd7IOUAh3pTEyqrUovz4otKc1OJDjNIcLErivFEGEyOEBNITS1KzU1MLUotgskwc nFINjAquO9pltcQE+qZlP05iuXk4LbBy2uL4DT8b7fzC7ko5d0gwFJ2ebvyztG5rXXPi/VaB SRWz+fNm8jwVWLZDIO9OfKpxUPAFvhd/K7R+3m892PVEYnP02UvhZ7ky3jPosPjFvn3p0Ltr F1/O0aKX23Z/D9pVdfgAd+6q3RnGTuEuLN//Kog3KrEUZyQaajEXFScCAOBrkFxPAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsVy+t9jQd39509HGOzZrmLxd9IxdotJT94z W/xs38JksenxNVaLYzseMVlc3jWHzWJ/7wYmi1PXP7NZXOqfyGRxZtUtdotfy48yOnB7XL52 kdnj969JjB7vb7SyezyY+p/JY+esu+wem1Z1snlsXlLvceVEE6vH8RvbmTw+b5IL4Ipys8lI TUxJLVJIzUvOT8nMS7dVCg1x07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2C W8by7c/YClbzVJy9I9/A+JKzi5GTQ0LARGLatclsELaYxIV764FsLg4hgVmMEpdaPrNCOF8Z JTpeH2IBqWITsJKY2L6KEcQWEZCVuDLtISNIEbNAI7PEmd+3mEASwgLOEpcvPQNq4OBgEVCV OHdRGCTMK6ApsfPdAWYQW1TAS2LLvnawck6gKy6e/Ae1eTmjRPPTyYwQDYISPybfA1vMLCAv sW//VFYIW0ti/c7jTBMYge5EKJuFpGwWkrIFjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS 83M3MYKj95n0DsbDu9wPMQpwMCrx8ArMPxUhxJpYVlyZe4hRgoNZSYQ3cs7pCCHelMTKqtSi /Pii0pzU4kOMpkAPTmSWEk3OByaWvJJ4QxNzE3NjAwtzS0sTIyVx3sbZz8KFBNITS1KzU1ML Uotg+pg4OKUaGLt9lyjw/rt71HRJx50551TLm467zvv4wSyvNd7w+Qv5o/bhE275TH2c6rln xWmfjurDC7JbdhXPz018/NjR56E9iy33Dddv/UanXwfvd1QM2l737DbPs4tlDDMEw5f6qvi5 Nvnp1GU3HzEwTtm921fSeGLX3VD+ZI7u9e9nt39Ovsq/pH6RuBJLcUaioRZzUXEiACk7eTb0 AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170317115959epcas5p1ea11eb64086e0c9febb2efab1e5d30ac X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170314175046epcas1p43f98daad14a2bac7f314e7d39e120232 X-RootMTR: 20170314175046epcas1p43f98daad14a2bac7f314e7d39e120232 References: <3458240.9SL7iGif3L@amdc3058> <20170316212654.GD1480@htj.duckdns.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday, March 16, 2017 05:26:54 PM Tejun Heo wrote: > Hello, > > On Tue, Mar 14, 2017 at 06:50:43PM +0100, Bartlomiej Zolnierkiewicz wrote: > > +static struct ata_port_operations pcmcia_ebsa110_port_ops = { > > + .inherits = &ata_sff_port_ops, > > + .sff_dev_select = pmcmia_ebsa110_dev_select, > ^^^^^^ > > + .sff_set_devctl = pcmcia_ebsa110_set_devctl, > > + .sff_check_status = pcmcia_ebsa110_check_status, > > + .sff_check_altstatus = pcmcia_ebsa110_check_altstatus, > > + .sff_tf_load = pcmcia_ebsa110_tf_load, > > + .sff_tf_read = pcmcia_ebsa110_tf_read, > > + .sff_exec_command = pcmcia_ebsa110_exec_command, > > + .sff_data_xfer = ata_sff_data_xfer_noirq, > > + .softreset = pata_pcmcia_ebsa110_softreset, > > + .cable_detect = ata_cable_40wire, > > + .set_mode = pcmcia_set_mode, > > +}; > > Heh, that's a fat driver for a sff device. I suppose this is mostly > copied from the matching ide driver but it'd be nice to explain why it > needs duplicate most standard functions. Is it because PCMCIA > assigned address doesn't fall under the usual read/io boundary on the > arch? There is no support for this device in the upstream ide driver but Russell has a hacky patch to make it work by redefining inb()/outb() operations globally for the whole ide subsystem, please see: https://www.spinics.net/lists/arm-kernel/msg567454.html and arch/arm/mach-ebsa110/io.c Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics