From: Frank Werner-Krippendorf <mail@kripp.ch>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Larry.Finger@lwfinger.net,
Frank Werner-Krippendorf <mail@kripp.ch>
Subject: [PATCH] Staging: rtl8712: rtl871x: removed unused code, to fix a coding style issue
Date: Sun, 5 Aug 2018 19:12:32 +0200 [thread overview]
Message-ID: <1533489152-19472-1-git-send-email-mail@kripp.ch> (raw)
Fixed a coding style issue.
Signed-off-by: Frank Werner-Krippendorf <mail@kripp.ch>
---
drivers/staging/rtl8712/rtl871x_event.h | 10 +++++-----
drivers/staging/rtl8712/rtl871x_io.h | 2 +-
drivers/staging/rtl8712/rtl871x_pwrctrl.h | 10 +++++-----
drivers/staging/rtl8712/rtl871x_xmit.h | 14 +++++++-------
4 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_event.h b/drivers/staging/rtl8712/rtl871x_event.h
index 5171379..2e59e8e 100644
--- a/drivers/staging/rtl8712/rtl871x_event.h
+++ b/drivers/staging/rtl8712/rtl871x_event.h
@@ -90,13 +90,13 @@ struct event_node {
unsigned char *node;
unsigned char evt_code;
unsigned short evt_sz;
- /*volatile*/ int *caller_ff_tail;
+ int *caller_ff_tail;
int caller_ff_sz;
};
struct c2hevent_queue {
- /*volatile*/ int head;
- /*volatile*/ int tail;
+ int head;
+ int tail;
struct event_node nodes[C2HEVENT_SZ];
unsigned char seq;
};
@@ -104,8 +104,8 @@ struct c2hevent_queue {
#define NETWORK_QUEUE_SZ 4
struct network_queue {
- /*volatile*/ int head;
- /*volatile*/ int tail;
+ int head;
+ int tail;
struct wlan_bssid_ex networks[NETWORK_QUEUE_SZ];
};
diff --git a/drivers/staging/rtl8712/rtl871x_io.h b/drivers/staging/rtl8712/rtl871x_io.h
index dd054d7..61d9e41 100644
--- a/drivers/staging/rtl8712/rtl871x_io.h
+++ b/drivers/staging/rtl8712/rtl871x_io.h
@@ -113,7 +113,7 @@ struct _io_ops {
struct io_req {
struct list_head list;
u32 addr;
- /*volatile*/ u32 val;
+ u32 val;
u32 command;
u32 status;
u8 *pbuf;
diff --git a/drivers/staging/rtl8712/rtl871x_pwrctrl.h b/drivers/staging/rtl8712/rtl871x_pwrctrl.h
index bd2c3a2..6451beb 100644
--- a/drivers/staging/rtl8712/rtl871x_pwrctrl.h
+++ b/drivers/staging/rtl8712/rtl871x_pwrctrl.h
@@ -89,14 +89,14 @@ struct reportpwrstate_parm {
struct pwrctrl_priv {
struct mutex mutex_lock;
- /*volatile*/ u8 rpwm; /* requested power state for fw */
+ u8 rpwm; /* requested power state for fw */
/* fw current power state. updated when 1. read from HCPWM or
* 2. driver lowers power level
*/
- /*volatile*/ u8 cpwm;
- /*volatile*/ u8 tog; /* toggling */
- /*volatile*/ u8 cpwm_tog; /* toggling */
- /*volatile*/ u8 tgt_rpwm; /* wanted power state */
+ u8 cpwm;
+ u8 tog; /* toggling */
+ u8 cpwm_tog; /* toggling */
+ u8 tgt_rpwm; /* wanted power state */
uint pwr_mode;
uint smart_ps;
uint alives;
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
index 4092727..aac0e14 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.h
+++ b/drivers/staging/rtl8712/rtl871x_xmit.h
@@ -160,8 +160,8 @@ struct xmit_frame {
_pkt *pkt;
int frame_tag;
struct _adapter *padapter;
- u8 *buf_addr;
- struct xmit_buf *pxmitbuf;
+ u8 *buf_addr;
+ struct xmit_buf *pxmitbuf;
u8 *mem_addr;
u16 sz[8];
struct urb *pxmit_urb[8];
@@ -194,11 +194,11 @@ struct sta_xmit_priv {
};
struct hw_txqueue {
- /*volatile*/ sint head;
- /*volatile*/ sint tail;
- /*volatile*/ sint free_sz; /*in units of 64 bytes*/
- /*volatile*/ sint free_cmdsz;
- /*volatile*/ sint txsz[8];
+ sint head;
+ sint tail;
+ sint free_sz; /*in units of 64 bytes*/
+ sint free_cmdsz;
+ sint txsz[8];
uint ff_hwaddr;
uint cmd_hwaddr;
sint ac_tag;
--
2.7.4
next reply other threads:[~2018-08-05 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 17:12 Frank Werner-Krippendorf [this message]
2018-08-05 18:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533489152-19472-1-git-send-email-mail@kripp.ch \
--to=mail@kripp.ch \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®