From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BBC2C4646D for ; Wed, 8 Aug 2018 14:38:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEE66214FE for ; Wed, 8 Aug 2018 14:38:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEE66214FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727309AbeHHQ6u (ORCPT ); Wed, 8 Aug 2018 12:58:50 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:38965 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726875AbeHHQ6u (ORCPT ); Wed, 8 Aug 2018 12:58:50 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3A7CBD7A156C7; Wed, 8 Aug 2018 22:38:33 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.399.0; Wed, 8 Aug 2018 22:38:28 +0800 From: zhong jiang To: , CC: , Subject: [PATCH] drivers/net/usb/r8152: change rtl8152_system_suspend to be void function Date: Wed, 8 Aug 2018 22:26:47 +0800 Message-ID: <1533738407-10495-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtl8152_system_suspend defines the variable "ret", but it is not modified after initialization. Further, I find that any of the callees do not handle the return value. So It is safe to drop the variable and make it to be void function. Signed-off-by: zhong jiang --- drivers/net/usb/r8152.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 124211a..cc51ac8 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -4412,10 +4412,9 @@ static int rtl8152_runtime_suspend(struct r8152 *tp) return ret; } -static int rtl8152_system_suspend(struct r8152 *tp) +static void rtl8152_system_suspend(struct r8152 *tp) { struct net_device *netdev = tp->netdev; - int ret = 0; netif_device_detach(netdev); @@ -4429,8 +4428,6 @@ static int rtl8152_system_suspend(struct r8152 *tp) tp->rtl_ops.down(tp); napi_enable(napi); } - - return ret; } static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message) @@ -4443,7 +4440,7 @@ static int rtl8152_suspend(struct usb_interface *intf, pm_message_t message) if (PMSG_IS_AUTO(message)) ret = rtl8152_runtime_suspend(tp); else - ret = rtl8152_system_suspend(tp); + rtl8152_system_suspend(tp); mutex_unlock(&tp->control); -- 1.7.12.4