From: zhong jiang <zhongjiang@huawei.com>
To: <axboe@kernel.dk>, <jthumshirn@suse.de>, <martin.petersen@oracle.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] drivers/block/mtip32xx: remove the null check for debugfs_remove_recursive
Date: Wed, 8 Aug 2018 22:58:33 +0800 [thread overview]
Message-ID: <1533740313-11906-1-git-send-email-zhongjiang@huawei.com> (raw)
debugfs_remove_recursive has taken null pointer into account. So it is
safe to drop the null check before calling the funtion.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/block/mtip32xx/mtip32xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 2b6d6bc..d0666f5c 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -2574,8 +2574,7 @@ static int mtip_hw_debugfs_init(struct driver_data *dd)
static void mtip_hw_debugfs_exit(struct driver_data *dd)
{
- if (dd->dfs_node)
- debugfs_remove_recursive(dd->dfs_node);
+ debugfs_remove_recursive(dd->dfs_node);
}
/*
--
1.7.12.4
next reply other threads:[~2018-08-08 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 14:58 zhong jiang [this message]
2018-08-08 15:16 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533740313-11906-1-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=axboe@kernel.dk \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®