From: zhong jiang <zhongjiang@huawei.com>
To: <axboe@kernel.dk>, <ed.cashin@acm.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] drivers/block/aoe/aoedev: NULL check is not needed for mempool_destroy
Date: Wed, 8 Aug 2018 23:00:35 +0800 [thread overview]
Message-ID: <1533740435-12088-1-git-send-email-zhongjiang@huawei.com> (raw)
mempool_destroy has taken the null pointer into account. So it is safe
to remove the null check.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/block/aoe/aoedev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index 697f735..41060e9 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -284,8 +284,8 @@
e = t + d->ntargets;
for (; t < e && *t; t++)
freetgt(d, *t);
- if (d->bufpool)
- mempool_destroy(d->bufpool);
+
+ mempool_destroy(d->bufpool);
skbpoolfree(d);
minor_free(d->sysminor);
--
1.7.12.4
next reply other threads:[~2018-08-08 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 15:00 zhong jiang [this message]
2018-08-08 15:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533740435-12088-1-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=axboe@kernel.dk \
--cc=ed.cashin@acm.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®