From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5468B1CDFA9 for ; Mon, 13 Jan 2025 23:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736809603; cv=none; b=aN3duIY/1a7ZC7X58RUtGhNpONaOdeCB9/wXRZMhyG5HhIyjfTBPJMIUaP3mtKEJcxyHmJClYcgaPNqxLb2FG4zjk3mHW/3pi6w/X+9QuqKSYa9CLLL/8pXbkwaNU63I0dRzBixiSdrLqQAHbHC3oOgBXFTEaeG++ajcn0RNdhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736809603; c=relaxed/simple; bh=FY3CAUHnUAGPlAvnTqBwytKqjfIe0H96ZK2+kvt3Gpo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SNgbD+hANurzUoZztFk86rVye81tzxu43qQRtIhv2FSk0Xq0F1pxa9SAp6kPdWhmcke0ftms/Kfj+tOgKj/O8i5uoiV67Nnwfu3OxuisjATmoIQhYGI8TipK4l4O0zlAowiFNM3LATjHaVO3ypIIZsP1E1osiCP7CYd1sePavxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=fGN55zD+; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="fGN55zD+" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-84a012f7232so188885439f.0 for ; Mon, 13 Jan 2025 15:06:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1736809600; x=1737414400; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t98L05cLqoN9QlNAdFWwtAB2uSyAKNpsq0R3tlTJnx4=; b=fGN55zD+QPKLTIC1ERc58hM9umFVkrs3t9SSVj3jKPYQaee3iswV/0spT0NsKCUget JEyaj3elRNTisN9FN7FtU5LE4NLRwVksQ6Iqm7IzCO96TvYeJpyB84YBTzrg3KQtZIFP uHobzoMZG9AS9FwjzAsqrxgm2ABSeadHkVotc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736809600; x=1737414400; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t98L05cLqoN9QlNAdFWwtAB2uSyAKNpsq0R3tlTJnx4=; b=m/IkeekBI2LiWAvawM0GVf4SfYvixMzTUC9iwCkAcQoACUSX85K+7vYDNwJ/kCDAgm NZb0fgdBz85odfhTBMW21gUN/5ee3iFMvW54hrri6JvidLlYHTk0LvaASPlb+HTqcvsX EYYDJHTgU8Uae9O/nzo9LzPfusMTOErX+8Sybe5SKyJBwvzxjZLFtud3DnLNNArKFDHs fDJ4eo3NJY10QjtQziBPQNsYpO4vOSLUIeohUtnq3/UcHn4coDdG97trZvLFyE5fEhu9 pYpNO9s3KCXI0yduBit9ri0hsqbtuetva6dOiySMaDjvP+jZ6qlANG2xMNpc1oA9AzjD oJcg== X-Gm-Message-State: AOJu0Yz2ONDcE55yeXw5z2sCisGo3uwrNvnY+nQgGzOTQP6os71/9DBS dPoQ2wC7tivbXDPYdBP7fersMk3j+b+FJ5u2s67DHwq88Rz80waocTm1ikAbOcA= X-Gm-Gg: ASbGncsv6SojyLurCEpPHkWJiSBkoYZZjOu5LFZWI96QQCzzNcCtwGinJpgaQsSLSgx fVtdAI2V2xm0CVHwP7UAEfNzVxXHafX9XbWzCj3wQ/llmu60lCh+F9uvImKGN/kPSn6NE7vNDt6 CbwD6n/P2sypCYPekJgSeqCe2l9l4dhVhhrHM8qAAIVf9sNJDB/1ug6KZqdnJnx73+Ym0nztbtD vHVe6SEZL9WPJaf34OeylLyNdrQLdsr0E+OtpDD9vh2F9v1hpJKaaX/DmC51QQhnMc= X-Google-Smtp-Source: AGHT+IH8D8/WA3nsz270K68ibq75FwpYAmp8r79kGSFWGw5muQ30GDD6Uv2Knph7vskIzmqScVtI3A== X-Received: by 2002:a05:6e02:1a8f:b0:3cd:c260:9f55 with SMTP id e9e14a558f8ab-3ce47570cd3mr131591595ab.4.1736809600570; Mon, 13 Jan 2025 15:06:40 -0800 (PST) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ea1b717838sm3014196173.102.2025.01.13.15.06.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 15:06:40 -0800 (PST) Message-ID: <15339541-8912-4a1f-b5ca-26dd825dfb88@linuxfoundation.org> Date: Mon, 13 Jan 2025 16:06:39 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/rseq: Fix rseq for cases without glibc support To: Raghavendra Rao Ananta , Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, stable@vger.kernel.org, Shuah Khan References: <20241210224435.15206-1-rananta@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241210224435.15206-1-rananta@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/10/24 15:44, Raghavendra Rao Ananta wrote: > Currently the rseq constructor, rseq_init(), assumes that glibc always > has the support for rseq symbols (__rseq_size for instance). However, > glibc supports rseq from version 2.35 onwards. As a result, for the > systems that run glibc less than 2.35, the global rseq_size remains > initialized to -1U. When a thread then tries to register for rseq, > get_rseq_min_alloc_size() would end up returning -1U, which is > incorrect. Hence, initialize rseq_size for the cases where glibc doesn't > have the support for rseq symbols. > > Cc: stable@vger.kernel.org > Fixes: 73a4f5a704a2 ("selftests/rseq: Fix mm_cid test failure") > Signed-off-by: Raghavendra Rao Ananta > --- Applied to linux_kselftest next for Linux 6.14-rc1 after fixing the commit if for Fixes tag thanks, -- Shuah