From: zhong jiang <zhongjiang@huawei.com>
To: <alcooperx@gmail.com>, <kishon@ti.com>, <robh@kernel.org>,
<hauke@hauke-m.de>, <ralf@linux-mips.org>
Cc: <f.fainelli@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCHv2 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open coded version
Date: Thu, 16 Aug 2018 23:58:55 +0800 [thread overview]
Message-ID: <1534435135-49332-3-git-send-email-zhongjiang@huawei.com> (raw)
In-Reply-To: <1534435135-49332-1-git-send-email-zhongjiang@huawei.com>
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c b/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c
index 986224f..a918c5b 100644
--- a/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c
+++ b/drivers/phy/lantiq/phy-lantiq-rcu-usb2.c
@@ -196,10 +196,8 @@ static int ltq_rcu_usb2_of_parse(struct ltq_rcu_usb2_priv *priv,
}
priv->phy_reset = devm_reset_control_get_optional(dev, "phy");
- if (IS_ERR(priv->phy_reset))
- return PTR_ERR(priv->phy_reset);
- return 0;
+ return PTR_ERR_OR_ZERO(priv->phy_reset);
}
static int ltq_rcu_usb2_phy_probe(struct platform_device *pdev)
--
1.7.12.4
next prev parent reply other threads:[~2018-08-16 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 15:58 [PATCHv2 0/2] phy: " zhong jiang
2018-08-16 15:58 ` [PATCHv2 1/2] phy:phy-brcm-usb: " zhong jiang
2018-08-16 15:58 ` zhong jiang [this message]
2018-08-25 14:16 ` [PATCHv2 2/2] phy:phy-lantiq-rcu-usb2: " Hauke Mehrtens
2018-08-23 11:21 ` [PATCHv2 0/2] phy: " zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534435135-49332-3-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=alcooperx@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®