From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755429AbcITQLZ (ORCPT ); Tue, 20 Sep 2016 12:11:25 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:61017 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754001AbcITQLW (ORCPT ); Tue, 20 Sep 2016 12:11:22 -0400 From: "Rafael J. Wysocki" To: Sebastian Andrzej Siewior Cc: peterz@infradead.org, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, Borislav Petkov Subject: Re: [PATCH] cpufreq: fix up conversion to hotplug state machine Date: Tue, 20 Sep 2016 18:17:36 +0200 Message-ID: <1534771.MnBsZb4zcz@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.8.0-rc2+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160920145628.lp2bmq72ip3oiash@linutronix.de> References: <20160906170457.32393-13-bigeasy@linutronix.de> <20160920145628.lp2bmq72ip3oiash@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 20, 2016 04:56:28 PM Sebastian Andrzej Siewior wrote: > The function cpufreq_register_driver() returns zero on success and since > commit 27622b061eb4 ("cpufreq: Convert to hotplug state machine") > erroneously a positive number. Due to the "if (x) assume_error" construct > all callers assumed an error and things went south. > This patch resets the return value back to zero in the success case. > > Fixes: 27622b061eb4 ("cpufreq: Convert to hotplug state machine") > Reported-by: Borislav Petkov > Signed-off-by: Sebastian Andrzej Siewior ACK > --- > drivers/cpufreq/cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index e0bc632a259e..8b44de4d7438 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -2503,6 +2503,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) > if (ret < 0) > goto err_if_unreg; > hp_online = ret; > + ret = 0; > > pr_debug("driver %s up and running\n", driver_data->name); > goto out; >