mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Richard Henderson <rth@twiddle.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch non-x86] PCI-PCI bridges fix
Date: Fri, 23 Nov 2001 08:49:30 +1100 (EST)	[thread overview]
Message-ID: <15357.29418.938012.421837@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20011122150418.A623@jurassic.park.msu.ru>
In-Reply-To: <20011122150418.A623@jurassic.park.msu.ru>

Ivan Kokshaysky writes:

> Bridge resources weren't added to the resource tree. This was
> harmless for most real-life configurations (especially on Alpha),
> but certainly it will be a problem with the hotplug stuff
> (thinking of ES45).
> 
> Ivan.
> 
> --- 2.4.15p9/drivers/pci/setup-bus.c	Fri Oct  5 05:47:08 2001
> +++ linux/drivers/pci/setup-bus.c	Wed Nov 21 20:16:24 2001
> @@ -201,6 +201,16 @@ pbus_assign_resources(struct pci_bus *bu
>  		b->resource[0]->end = ranges->io_end - 1;
>  		b->resource[1]->end = ranges->mem_end - 1;
>  
> +		/* Add bridge resources to the resource tree. */
> +		if (b->resource[0]->end > b->resource[0]->start &&
> +		    request_resource(bus->resource[0], b->resource[0]) < 0)
> +			printk(KERN_ERR "PCI: failed to reserve IO "
> +					"for bus %d\n",	b->number);

There is code in pci_read_bridge_bases which will decide under some
circumstances that a PCI-PCI bridge is transparent and set

	child->resource[i] = child->parent->resource[i];

for i = 0, 1 or 2.  What will happen with your request_resource in
this case is that the resource will end up being its own parent and
its own child and all allocations against it will fail. :)

I hit this just yesterday on PPC.  On our RS/6000 boxes, if you have a
PCI-PCI bridge with nothing behind it, the firmware will configure it
with all the apertures closed, i.e. with base set larger than limit.
Then pci_read_bridge_bases goes and decides that the bridge is
transparent and consequently everything stops working. :(

Does anyone really need that "assuming transparent" stuff in
pci_read_bridge_bases?  If so we need to add a check for the case
where base == limit + 0x1000 (for I/O) or base == limit + 0x100000
(for memory) and conclude that the aperture is closed in that case.

Paul.

  reply	other threads:[~2001-11-22 21:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-22 12:04 Ivan Kokshaysky
2001-11-22 21:49 ` Paul Mackerras [this message]
2001-11-23 12:36   ` Ivan Kokshaysky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15357.29418.938012.421837@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®