mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [NFS] Re: Fix knfsd readahead cache in 2.4.15
Date: Tue, 27 Nov 2001 14:54:46 +0100	[thread overview]
Message-ID: <15363.39718.446155.619699@charged.uio.no> (raw)
In-Reply-To: <20011126202509.J15582@redhat.com>
In-Reply-To: <15362.18626.303009.379772@charged.uio.no> <15362.53694.192797.275363@esther.cse.unsw.edu.au> <20011126.155347.45872112.davem@redhat.com> <20011126202509.J15582@redhat.com>

>>>>> " " == Benjamin LaHaise <bcrl@redhat.com> writes:

     > Hint: readahead via the page cache is the way to go...

That's not the problem: knfsd has always done readahead via the page
cache.

The problem is that the generic_file_read() stuff caches info about
the status of readaheads in the 'struct file', which is a volatile
object in NFS (it is released after the NFS request has been serviced).
To work around that, knfsd copies that readahead status data from the
struct file into a private cache, and trots it out again upon the next
READ call to reference that particular inode.

Cheers,
   Trond

  parent reply	other threads:[~2001-11-27 13:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-26 13:50 Trond Myklebust
2001-11-26 23:35 ` Neil Brown
2001-11-27  0:05   ` David S. Miller
2001-11-26 23:53 ` David S. Miller
2001-11-27  0:29   ` Neil Brown
2001-11-27  0:33   ` David S. Miller
2001-11-27  1:25   ` [NFS] " Benjamin LaHaise
2001-11-27 13:54   ` Trond Myklebust [this message]
2001-11-27 15:23     ` Benjamin LaHaise
2001-11-27 15:44     ` Trond Myklebust
2001-11-28 21:03       ` Benjamin LaHaise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15363.39718.446155.619699@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=bcrl@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®