mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wang Dongsheng <dongsheng.wang@hxt-semitech.com>
To: <jeffrey.t.kirsher@intel.com>, <sergei.shtylyov@cogentembedded.com>
Cc: <jacob.e.keller@intel.com>, <davem@davemloft.net>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Wang Dongsheng <dongsheng.wang@hxt-semitech.com>
Subject: [PATCH v3 0/2] net: ethernet: i40e/i40evf fix build error
Date: Fri, 7 Sep 2018 19:19:33 +0800	[thread overview]
Message-ID: <1536319175-3660-1-git-send-email-dongsheng.wang@hxt-semitech.com> (raw)

i40e: function __i40e_add_stat_strings can never be inlined because it uses
variable argument lists.

i40evf: A risk of "Multiple definition" from cross-including.

I am working on aarch64 platform and unfortunately the config file is MODULE.
So I missed the buildin test... Sorry for pushing this patch to v3 version...

Now I tested this patch with buildin and modules.

Tested on: x86_64, make ARCH=i386

Modules section .text:
i40e: 00019380 <__i40e_add_stat_strings>:
i40evf: 00006b00 <__i40e_add_stat_strings>:

Buildin:
i40e: c351ca60 <__i40e_add_stat_strings>:
i40evf: c354f2c0 <__i40e_add_stat_strings>:


Wang Dongsheng (2):
  net: ethernet: i40e: fix build error
  net: ethernet: i40evf: fix underlying build error

 .../net/ethernet/intel/i40e/i40e_ethtool.c    | 24 ++++++++++++++++++
 .../ethernet/intel/i40e/i40e_ethtool_stats.h  | 25 ++-----------------
 .../intel/i40evf/i40e_ethtool_stats.h         | 23 +----------------
 .../ethernet/intel/i40evf/i40evf_ethtool.c    | 24 ++++++++++++++++++
 4 files changed, 51 insertions(+), 45 deletions(-)

-- 
2.18.0


             reply	other threads:[~2018-09-07 11:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 11:19 Wang Dongsheng [this message]
2018-09-07 11:19 ` [PATCH v3 1/2] net: ethernet: i40e: " Wang Dongsheng
2018-09-07 12:40   ` Wang, Dongsheng
2018-09-07 21:42     ` Keller, Jacob E
2018-09-07 15:27   ` Keller, Jacob E
2018-09-07 11:19 ` [PATCH v3 2/2] net: ethernet: i40evf: fix underlying " Wang Dongsheng
2018-09-07 12:34   ` Wang, Dongsheng
2018-09-07 15:26     ` Wyborny, Carolyn
2018-09-07 17:29       ` Wang, Dongsheng
2018-09-07 15:33   ` Sergei Shtylyov
2018-09-07 17:14     ` Wang, Dongsheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1536319175-3660-1-git-send-email-dongsheng.wang@hxt-semitech.com \
    --to=dongsheng.wang@hxt-semitech.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®