mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
To: <balbi@kernel.org>, <gregkh@linuxfoundation.org>
Cc: <v.anuragkumar@gmail.com>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <Thinh.Nguyen@synopsys.com>,
	<apandey@xilinx.com>,
	Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Subject: [PATCH v5 8/8] usb: dwc3: Check MISSED ISOC bit only for ISOC endpoints
Date: Sat, 15 Sep 2018 20:00:01 +0530	[thread overview]
Message-ID: <1537021801-23896-9-git-send-email-anurag.kumar.vulisha@xilinx.com> (raw)
In-Reply-To: <1537021801-23896-1-git-send-email-anurag.kumar.vulisha@xilinx.com>

When streaming is enabled on BULK endpoints and LST bit is set
observed MISSED ISOC bit set in event->status for BULK ep. Since
this bit is only valid for isocronous endpoints, changed the code
to check for isocrnous endpoints when MISSED ISOC bit is set.

Signed-off-by: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Reviewed-by: Thinh Nguyen <thinhn@synopsys.com>
---
 Changes in v5:
	1. None

 Changes in v4:
	1. None

 Changes in v3:
	1. None

 Changes in v2:
	1. None
---
 drivers/usb/dwc3/gadget.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 872c956..0b6d859 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2422,7 +2422,8 @@ static void dwc3_gadget_endpoint_transfer_in_progress(struct dwc3_ep *dep,
 	if (event->status & DEPEVT_STATUS_BUSERR)
 		status = -ECONNRESET;
 
-	if (event->status & DEPEVT_STATUS_MISSED_ISOC) {
+	if ((event->status & DEPEVT_STATUS_MISSED_ISOC) &&
+	    usb_endpoint_xfer_isoc(dep->endpoint.desc)) {
 		status = -EXDEV;
 
 		if (list_empty(&dep->started_list))
-- 
2.1.1


  parent reply	other threads:[~2018-09-15 14:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-15 14:29 [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 1/8] usb: dwc3: Correct the logic for checking TRB full in __dwc3_prepare_one_trb() Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 2/8] usb: dwc3: update stream id in depcmd Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 3/8] usb: dwc3: make controller clear transfer resources after complete Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 4/8] usb: dwc3: implement stream transfer timeout Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 5/8] usb: dwc3: don't issue no-op trb for stream capable endpoints Anurag Kumar Vulisha
2018-09-15 14:29 ` [PATCH v5 6/8] usb: dwc3: check for requests in started list " Anurag Kumar Vulisha
2018-09-15 14:30 ` [PATCH v5 7/8] usb: dwc3: Check for IOC/LST bit in both event->status and TRB->ctrl fields Anurag Kumar Vulisha
2018-09-15 14:30 ` Anurag Kumar Vulisha [this message]
2018-09-21  2:53 ` [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver Tejas Joglekar
2018-09-21 13:31 ` Tejas Joglekar
2018-09-21 14:05   ` Anurag Kumar Vulisha
2018-09-24  4:57     ` Tejas Joglekar
2018-10-08 15:25 ` Anurag Kumar Vulisha
2018-10-09  5:36   ` Felipe Balbi
2018-10-09  6:38     ` Anurag Kumar Vulisha
2018-10-09  7:20       ` Felipe Balbi
2018-10-09 13:00         ` Anurag Kumar Vulisha
2018-10-09 13:04           ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1537021801-23896-9-git-send-email-anurag.kumar.vulisha@xilinx.com \
    --to=anurag.kumar.vulisha@xilinx.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=apandey@xilinx.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=v.anuragkumar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®