From: Johannes Berg <johannes@sipsolutions.net>
To: Erik Stromdahl <erik.stromdahl@gmail.com>,
davem@davemloft.net, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix issue with possible txq NULL pointer
Date: Mon, 17 Sep 2018 09:40:50 +0200 [thread overview]
Message-ID: <1537170050.2957.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20180914160034.2753-1-erik.stromdahl@gmail.com> (sfid-20180914_180044_364636_63E0B0A6)
On Fri, 2018-09-14 at 18:00 +0200, Erik Stromdahl wrote:
> Drivers that do not have the BUFF_MMPDU_TXQ flag set will not have a
> TXQ for the special TID = 16.
>
> In this case, the last member in the *struct ieee80211_sta* txq array
> will be NULL.
>
> We must check this in order not to get a NULL pointer dereference when
> iterating the txq array.
Uh, yes, thanks. This is my fault - I merged the overlapping patches
closely together.
johannes
prev parent reply other threads:[~2018-09-17 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 16:00 Erik Stromdahl
2018-09-17 7:40 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537170050.2957.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=erik.stromdahl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome