From: Eugen Hristev <eugen.hristev@microchip.com>
To: <jic23@kernel.org>, <ludovic.desroches@microchip.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>
Cc: <nicolas.ferre@microchip.com>,
Eugen Hristev <eugen.hristev@microchip.com>,
Maxime Ripard <maxime.ripard@bootlin.com>
Subject: [PATCH v2 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions
Date: Mon, 24 Sep 2018 10:51:43 +0300 [thread overview]
Message-ID: <1537775504-7981-1-git-send-email-eugen.hristev@microchip.com> (raw)
When doing simple conversions, the driver did not acknowledge the DRDY irq.
If this irq status is not acked, it will be left pending, and as soon as a
trigger is enabled, the irq handler will be called, it doesn't know why
this status has occurred because no channel is pending, and then it will go
int a irq loop and board will hang.
To avoid this situation, read the LCDR after a raw conversion is done.
Fixes 0e589d5fb ("ARM: AT91: IIO: Add AT91 ADC driver.")
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---
Hello Jonathan,
I moved this LCDR read/acknowledge into the IRQ handler after the conversion
value is being read.
Sorry about the noise to stable@vger, removed from message.
Thanks,
Eugen
drivers/iio/adc/at91_adc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 44b5168..e3be88e 100644
--- a/drivers/iio/adc/at91_adc.c
+++ b/drivers/iio/adc/at91_adc.c
@@ -279,6 +279,8 @@ static void handle_adc_eoc_trigger(int irq, struct iio_dev *idev)
iio_trigger_poll(idev->trig);
} else {
st->last_value = at91_adc_readl(st, AT91_ADC_CHAN(st, st->chnb));
+ /* Needed to ACK the DRDY interruption */
+ at91_adc_readl(st, AT91_ADC_LCDR);
st->done = true;
wake_up_interruptible(&st->wq_data_avail);
}
--
2.7.4
next reply other threads:[~2018-09-24 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 7:51 Eugen Hristev [this message]
2018-09-24 7:51 ` [PATCH v2 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode Eugen Hristev
2018-09-24 20:25 ` Jonathan Cameron
2018-09-25 13:17 ` Ludovic Desroches
2018-09-29 11:31 ` Jonathan Cameron
2018-09-24 20:23 ` [PATCH v2 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions Jonathan Cameron
2018-09-25 13:17 ` Ludovic Desroches
2018-09-29 11:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537775504-7981-1-git-send-email-eugen.hristev@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=maxime.ripard@bootlin.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome