From: David Mosberger <davidm@hpl.hp.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: davidm@hpl.hp.com, marcelo@conectiva.com.br (Marcelo Tosatti),
akpm@zip.com.au (Andrew Morton),
j-nomura@ce.jp.nec.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.16 kernel/printk.c (per processorinitializationcheck)
Date: Sat, 8 Dec 2001 16:58:15 -0800 [thread overview]
Message-ID: <15378.46887.160213.680268@napali.hpl.hp.com> (raw)
In-Reply-To: <E16CsFa-0003KV-00@the-village.bc.nu>
In-Reply-To: <15378.45358.807039.55719@napali.hpl.hp.com> <E16CsFa-0003KV-00@the-village.bc.nu>
>>>>> On Sun, 9 Dec 2001 00:55:25 +0000 (GMT), Alan Cox <alan@lxorguk.ukuu.org.uk> said:
>> I don't think you can do it early enough. calibrate_delay()
>> requires irqs to be enabled and the first printk() happens long
>> before irqs are enabled on an AP.
Alan> So we make sure our initial console code doesnt need udelay(),
Alan> or set an initial safe default like 25MHz
So someone is going to maintain a list of what a console driver can
and cannot do for all 12+ ports in existence?
The alternative is to do:
--- linux-2.4.16/kernel/printk.c Mon Nov 26 11:19:24 2001
+++ lia64-kdb/kernel/printk.c Thu Nov 29 21:45:08 2001
@@ -498,6 +505,10 @@
for ( ; ; ) {
spin_lock_irqsave(&logbuf_lock, flags);
must_wake_klogd |= log_start - log_end;
+#ifdef CONFIG_SMP
+ if (!(cpu_online_map & (1UL << smp_processor_id())))
+ break;
+#endif
if (con_start == log_end)
break; /* Nothing to print */
_con_start = con_start;
and be done with it.
--david
next prev parent reply other threads:[~2001-12-09 0:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-03 5:46 [PATCH] 2.4.16 kernel/printk.c (per processor initialization check) j-nomura
2001-12-03 9:20 ` Andrew Morton
2001-12-03 10:32 ` j-nomura
2001-12-04 1:45 ` [PATCH] 2.4.16 kernel/printk.c (per processor initializationcheck) Andrew Morton
2001-12-06 5:01 ` j-nomura
2001-12-07 3:40 ` [PATCH] 2.4.16 kernel/printk.c (per processorinitializationcheck) Andrew Morton
2001-12-07 18:52 ` Marcelo Tosatti
2001-12-07 20:52 ` William Lee Irwin III
2001-12-07 21:37 ` David Mosberger
2001-12-07 20:47 ` Marcelo Tosatti
2001-12-07 22:08 ` Alan Cox
2001-12-07 22:14 ` Christopher Friesen
2001-12-07 22:17 ` David Mosberger
2001-12-07 21:09 ` Marcelo Tosatti
2001-12-08 1:10 ` David Mosberger
2001-12-08 11:27 ` Alan Cox
2001-12-08 16:41 ` David Mosberger
2001-12-08 20:45 ` Alan Cox
2001-12-09 0:32 ` David Mosberger
2001-12-09 0:55 ` Alan Cox
2001-12-09 0:58 ` David Mosberger [this message]
2001-12-09 1:14 ` David Mosberger
2001-12-09 1:32 ` Alan Cox
2001-12-09 1:15 ` Alan Cox
2001-12-08 17:36 Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15378.46887.160213.680268@napali.hpl.hp.com \
--to=davidm@hpl.hp.com \
--cc=akpm@zip.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®