mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Jiri Kosina <trivial@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH trivial] reset: Improve reset controller kernel docs
Date: Mon, 08 Oct 2018 14:55:40 +0200	[thread overview]
Message-ID: <1539003340.11512.18.camel@pengutronix.de> (raw)
In-Reply-To: <20181008111543.26128-1-geert+renesas@glider.be>

Hi Geert,

On Mon, 2018-10-08 at 13:15 +0200, Geert Uytterhoeven wrote:
> Grammar and indentation fixes.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  include/linux/reset.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 29af6d6b2f4b8103..d01ea059e2beee6e 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -138,7 +138,7 @@ __must_check reset_control_get_exclusive(struct device *dev, const char *id)
>   *
>   * Returns a struct reset_control or IS_ERR() condition containing errno.
>   * This function is intended for use with reset-controls which are shared
> - * between hardware-blocks.
> + * among hardware blocks.

To my ears "between" sounds better, because it evokes the idea that each
hardware block individually must take care not to disturb any of the
others (like sharing a bike between a few riders, instead of among
them). Also, in many cases the sharing occurs between just two hardware
blocks, which makes "among" sound weird.
Of course I'm not a native speaker, so maybe I'm completely wrong.

The other fixes I agree with.

regards
Philipp

  reply	other threads:[~2018-10-08 12:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 11:15 Geert Uytterhoeven
2018-10-08 12:55 ` Philipp Zabel [this message]
2018-11-13 15:12   ` Geert Uytterhoeven
2018-11-13 14:28 ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539003340.11512.18.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®