From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756165Ab3LDW4g (ORCPT ); Wed, 4 Dec 2013 17:56:36 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:56984 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755434Ab3LDW4e (ORCPT ); Wed, 4 Dec 2013 17:56:34 -0500 From: "Rafael J. Wysocki" To: Aaron Lu Cc: Zhang Rui , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Lan Tianyu , Len Brown , Matthew Garrett Subject: Re: [PATCH 0/4] Convert ACPI fan driver to platform driver Date: Thu, 05 Dec 2013 00:09:33 +0100 Message-ID: <1539785.BAHHmmHfI6@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.12.0-rc6+; KDE/4.10.5; x86_64; ; ) In-Reply-To: <1654759.afJtadVnDQ@vostro.rjw.lan> References: <1386059312-2990-1-git-send-email-aaron.lu@intel.com> <1654759.afJtadVnDQ@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cc: +Matthew (sorry, omitted by mistake previously) On Thursday, December 05, 2013 12:07:31 AM Rafael J. Wysocki wrote: > On Tuesday, December 03, 2013 04:28:28 PM Aaron Lu wrote: > > This patchset converts ACPI fan driver to platform driver. Patch 1-3 are > > cleanups for existing fan driver and patch 4 does the convertion. > > > > Tested on harris beach. > > Apply on top of Rafael's linux-next branch. > > > > Aaron Lu (4): > > ACPI / fan: remove unused macro for debug > > ACPI / fan: remove no need check for device pointer > > ACPI / fan: use acpi_device_xxx_power instead of acpi_bus equivelant > > ACPI / fan: convert to platform driver > > > > drivers/acpi/acpi_platform.c | 3 ++ > > drivers/acpi/device_pm.c | 1 + > > drivers/acpi/fan.c | 88 ++++++++++++++++---------------------------- > > drivers/acpi/internal.h | 2 - > > include/acpi/acpi_bus.h | 1 + > > 5 files changed, 36 insertions(+), 59 deletions(-) > > Unfortunately, we need to postpone these conversions, because Matthew Garrett > has problems with adding more entries to acpi_platform_device_ids[]. He seems > to be concerned that that list will grow indefinitely and will become difficult > to maintain eventually. > > For this reason, he would prefer it if we did the following: > - Figure out the list of ACPI device IDs we need to create PNP devices for > via ACPI PNP. > - Make ACPI PNP create PNP devices for these IDs only and make the ACPI core create > platform devices for all "unassigned" ACPI device objects by default. > - Do the conversions at that point. > > I'm slightly worried that we'll encounter ordering issues while doing that, but > this is the only way forward I can see without going straight against the > Matthew's objections, which I'd prefer to avoid. > > Thanks, > Rafael > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.