From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752845AbdLEOMA (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Dec 2017 09:12:00 -0500
Received: from mailout1.samsung.com ([203.254.224.24]:49497 "EHLO
        mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751255AbdLEOL5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Dec 2017 09:11:57 -0500
DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171205141155epoutp0120e92f4e04267fcac55523cd16646ede~9a2FdQBTf1126211262epoutp01V
X-AuditID: b6c32a45-e63ff700000010f7-46-5a26a92b4bae
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: tj@kernel.org, sergei.shtylyov@cogentembedded.com,
        linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_pdc2027x: Fix coding sytle error
Date: Tue, 05 Dec 2017 15:12:08 +0100
Message-id: <1539928.BgA1Lm19hU@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <1823468.mnqCj3ft5Z@amdc3058>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsWy7bCmha72SrUog77zshbXehcyWxzb8YjJ
        4vKuOWwWZ1bdYrf4tfwoowOrx4Op/5k8ds66y+6xaVUnm8fnTXIBLFFcNimpOZllqUX6dglc
        GYvbHjIX/GCv6Dv9jbWBcSNbFyMnh4SAicSrpg1ANheHkMAORolNy/8xQzjfGSVm//jBDlP1
        sKeNESKxm1Hi9r/ZUC1fGSXW7v3DAlLFJmAlMbF9FSOILSKgI7Fp5m8wm1mgQOJW829WEFsY
        qGZt13Sw3SwCqhJnfp8H28AroCkxf+8LMFtUwEtiy752JhCbU0BL4sXu5UwQNYISPybfY4GY
        KS+xb/9UVghbR+LssXVg10kILGGTOH9nLtTZLhIfZ5+BelRY4tXxLVBxaYlnqzYyQtjTGSW2
        /5aAaN7MKLFq9wSoImuJw8cvQm3gk+g4/BcozgEU55XoaBOCMD0kWh5nQVQ7Suz4vQEaQpcZ
        JVbsfsY6gVF2FpK7ZyG5exaSuxcwMq9iFEstKM5NTy02KjDUK07MLS7NS9dLzs/dxAhOBFqu
        OxhnnPM5xCjAwajEw7tillqUEGtiWXFl7iFGCQ5mJRFe5n6gEG9KYmVValF+fFFpTmrxIUZp
        DhYlcd76bdcihATSE0tSs1NTC1KLYLJMHJxSDYzacfbJG9cqh01TTOrRX7yyoNBWT35l9omP
        W/LFlzDGeK2exyL/OER1851W9VdJBS8ey88p2LvObfdzQd8oHuHb6na6N387Nm1UrPapPPRF
        TtNEUONfj+Aejletm3de/8c+4UPbzRl9W3+5Ns6+FCiy5d11hqdRz95srEiaNalhibj1zfiN
        e4WUWIozEg21mIuKEwGZi+ciAAMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t9jAV3tlWpRBmemCFlc613IbHFsxyMm
        i8u75rBZnFl1i93i1/KjjA6sHg+m/mfy2DnrLrvHplWdbB6fN8kFsERx2aSk5mSWpRbp2yVw
        ZSxue8hc8IO9ou/0N9YGxo1sXYycHBICJhIPe9oYuxi5OIQEdjJKHPq/gQXC+coo0b60jRmk
        ik3ASmJi+ypGEFtEQEdi08zfYDazQIHE0QlTmUBsYaCatV3TwaayCKhKnPl9nh3E5hXQlJi/
        9wWYLSrgJbFlXztYPaeAlsSL3cuZIJZdZZTofL+ACaJBUOLH5HssEAvkJfbtn8oKYWtJrN95
        nGkCI/8sJGWzkJTNQlK2gJF5FaNkakFxbnpusVGBUV5quV5xYm5xaV66XnJ+7iZGYOhuO6zV
        v4Px8ZL4Q4wCHIxKPLwBM9SihFgTy4orcw8xSnAwK4nwMvcDhXhTEiurUovy44tKc1KLDzFK
        c7AoifPy5x+LFBJITyxJzU5NLUgtgskycXBKNTCGa8/RTOcyTzj9Ji5I2YZl8qL4lRWJ+iwz
        vtfKp/TIdCvEaP75NFF7h/mOSf6dDft1mb8G3jHvPbR7ziq1SSev7Kpiyd7hoRPh/cO6226D
        XaX57r872sR3Hf4kvPHUw82TGbK8p+xO3KyRdENp4enrqXLHf+g/aDo0bc+GdfmPLnx8sOLP
        6aCjSizFGYmGWsxFxYkAYBroVlkCAAA=
X-CMS-MailID: 20171205141155epcas2p4f368895924080af8dfaa2f6ef5b4cafa
X-Msg-Generator: CA
CMS-TYPE: 102P
X-CMS-RootMailID: 20171125103419epcas5p1e02e8409d9cb34cd3c592ca4e14961eb
X-RootMTR: 20171125103419epcas5p1e02e8409d9cb34cd3c592ca4e14961eb
References: <CGME20171125103419epcas5p1e02e8409d9cb34cd3c592ca4e14961eb@epcas5p1.samsung.com>
        <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com>
        <1823468.mnqCj3ft5Z@amdc3058>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, December 05, 2017 03:02:13 PM Bartlomiej Zolnierkiewicz wrote:
> On Saturday, November 25, 2017 04:04:07 PM Arvind Yadav wrote:
> > Fix these checkpatch.pl error:
> > ERROR: space prohibited before open square bracket '['.
> > 
> > ERROR: space prohibited after that '~' (ctx:WxW)
> > +		mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
> > 
> > ERROR: spaces required around that '?' (ctx:VxW)
> > +	long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
> > 
> > ERROR: that open brace { should be on the previous line
> > +	const struct ata_port_info *ppi[] =
> > +		{ &pdc2027x_port_info[board_idx], NULL };
> > 
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> 
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

PS two small things than still can be fixed:

* s/sytle error/style errors/ in the patch summary

* s/error/errors/ in the patch description

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics