From: Randy Dunlap <rdunlap@infradead.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Robert Marko <robert.marko@sartura.hr>,
Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH RESEND v5 1/3] ABI: sysfs-nvmem-cells: Expose cells through sysfs
Date: Thu, 13 Jul 2023 08:56:48 -0700 [thread overview]
Message-ID: <153c8781-a83a-d7d9-92b2-b82ca9ab06aa@infradead.org> (raw)
In-Reply-To: <20230713075508.485072-2-miquel.raynal@bootlin.com>
Hi,
On 7/13/23 00:55, Miquel Raynal wrote:
> The binary content of nvmem devices is available to the user so in the
> easiest cases, finding the content of a cell is rather easy as it is
> just a matter of looking at a known and fixed offset. However, nvmem
> layouts have been recently introduced to cope with more advanced
> situations, where the offset and size of the cells is not known in
> advance or is dynamic. When using layouts, more advanced parsers are
> used by the kernel in order to give direct access to the content of each
> cell regardless of their position/size in the underlying device, but
> these information were not accessible to the user.
>
> By exposing the nvmem cells to the user through a dedicated cell/ folder
> containing one file per cell, we provide a straightforward access to
> useful user information without the need for re-writing a userland
> parser. Content of nvmem cells is usually: product names, manufacturing
> date, MAC addresses, etc,
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Documentation/ABI/testing/sysfs-nvmem-cells | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-nvmem-cells
>
> diff --git a/Documentation/ABI/testing/sysfs-nvmem-cells b/Documentation/ABI/testing/sysfs-nvmem-cells
> new file mode 100644
> index 000000000000..641a7d7dad76
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-nvmem-cells
> @@ -0,0 +1,19 @@
> +What: /sys/bus/nvmem/devices/.../cells/<cell-name>
> +Date: May 2023
> +KernelVersion: 6.5
> +Contact: Miquel Raynal <miquel.raynal@bootlin.com>
> +Description:
> + The cells/ folder contains one file per cell exposed by
(My shell doesn't show "folders". ;)
> + the nvmem device. The name of the file is the cell name.
> + The length of the file is the size of the cell (when
> + known). The content of the file is the binary content of
> + the cell (may sometimes be ASCII, likely without
> + trailing character).
> + Note: This file is only present if CONFIG_NVMEM_SYSFS
> + is enabled
add ending '.': enabled.
> +
> + ex::
Example::
or
E.g.::
> +
> + hexdump -C /sys/bus/nvmem/devices/1-00563/cells/product-name
> + 00000000 54 4e 34 38 4d 2d 50 2d 44 4e |TN48M-P-DN|
> + 0000000a
--
~Randy
next prev parent reply other threads:[~2023-07-13 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 7:55 [PATCH RESEND v5 0/3] NVMEM cells in sysfs Miquel Raynal
2023-07-13 7:55 ` [PATCH RESEND v5 1/3] ABI: sysfs-nvmem-cells: Expose cells through sysfs Miquel Raynal
2023-07-13 15:56 ` Randy Dunlap [this message]
2023-07-16 13:59 ` Miquel Raynal
2023-07-13 7:55 ` [PATCH RESEND v5 2/3] nvmem: core: Create all cells before adding the nvmem device Miquel Raynal
2023-07-13 7:55 ` [PATCH RESEND v5 2/2] nvmem: core: Expose cells through sysfs Miquel Raynal
2023-07-13 9:16 ` Srinivas Kandagatla
2023-07-13 9:37 ` Miquel Raynal
2023-07-13 7:55 ` [PATCH RESEND v5 3/3] " Miquel Raynal
2023-07-13 9:55 ` [PATCH RESEND v5 0/3] NVMEM cells in sysfs Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153c8781-a83a-d7d9-92b2-b82ca9ab06aa@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=miquel.raynal@bootlin.com \
--cc=robert.marko@sartura.hr \
--cc=srinivas.kandagatla@linaro.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®