mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Florian Fainelli <f.fainelli@gmail.com>, <linux-kernel@vger.kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Sean V Kelley <seanvk.dev@oregontracks.org>,
	Jiri Olsa <jolsa@redhat.com>,
	"moderated list:ARM PMU PROFILING AND DEBUGGING" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] perf vendor events arm64: Remove [[:xdigit:]] wildcard
Date: Wed, 15 May 2019 10:02:01 +0100	[thread overview]
Message-ID: <153ce6d0-d4dd-ef2f-9fd7-47335cfeb67b@huawei.com> (raw)
In-Reply-To: <20190513202522.9050-2-f.fainelli@gmail.com>

On 13/05/2019 21:25, Florian Fainelli wrote:
> ARM64's implementation of get_cpuidr_str() masks out the revision bits
> [3:0] while reading the CPU identifier, there is no need for the
> [[:xdigit:]] wildcard.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv b/tools/perf/pmu-events/arch/arm64/mapfile.csv
> index 59cd8604b0bd..da5ff2204bf6 100644
> --- a/tools/perf/pmu-events/arch/arm64/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv
> @@ -12,7 +12,7 @@
>  #

JFYI, this was discussed before, but this a53 entry seemed to make it 
though:
https://lkml.org/lkml/2018/3/7/1236

>  #
>  #Family-model,Version,Filename,EventType
> -0x00000000410fd03[[:xdigit:]],v1,arm/cortex-a53,core
> +0x00000000410fd030,v1,arm/cortex-a53,core
>  0x00000000420f5160,v1,cavium/thunderx2,core
>  0x00000000430f0af0,v1,cavium/thunderx2,core
>  0x00000000480fd010,v1,hisilicon/hip08,core
>



  reply	other threads:[~2019-05-15  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 20:25 [PATCH v2 0/3] perf vendor events arm64: support for Brahma-B53, Cortex-A57/A72 Florian Fainelli
2019-05-13 20:25 ` [PATCH v2 1/3] perf vendor events arm64: Remove [[:xdigit:]] wildcard Florian Fainelli
2019-05-15  9:02   ` John Garry [this message]
2019-05-18  9:28   ` [tip:perf/core] " tip-bot for Florian Fainelli
2019-05-13 20:25 ` [PATCH v2 2/3] perf vendor events arm64: Map Brahma-B53 CPUID to cortex-a53 events Florian Fainelli
2019-05-18  9:29   ` [tip:perf/core] " tip-bot for Florian Fainelli
2019-05-13 20:25 ` [PATCH v2 3/3] perf vendor events arm64: Add Cortex-A57 and Cortex-A72 events Florian Fainelli
2019-05-18  9:30   ` [tip:perf/core] " tip-bot for Florian Fainelli
2019-05-15 19:13 ` [PATCH v2 0/3] perf vendor events arm64: support for Brahma-B53, Cortex-A57/A72 Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153ce6d0-d4dd-ef2f-9fd7-47335cfeb67b@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=f.fainelli@gmail.com \
    --cc=ganapatrao.kulkarni@cavium.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=seanvk.dev@oregontracks.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®