From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.manjaro.org (mail1.manjaro.org [142.132.176.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2EB3DE427; Tue, 16 Jun 2026 19:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=142.132.176.110 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781637013; cv=none; b=hiPDjBYwQRDIVKbM/pO5pCLsG6j9E2KZpu5U88UQYODTlXx5l7TN0F43rhvTTrDZ2A6nPPAmZk5MYvCUS00c+u0y4KJiV1Oh5YcvHDZcLiC7l49WVWQOvBG442/x2A9xcPUeXKH0fQgKxMsu7wXB9naqaGrWzhqnIf25S9w7Jg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781637013; c=relaxed/simple; bh=iC1y9jjurLW3r3T7CzmU920OFDZiKz4VEa/6HGxP/SY=; h=From:In-Reply-To:Content-Type:References:Date:Cc:To:MIME-Version: Message-ID:Subject; b=mvIiN/f6JlCsYtdNNX1FWjCpqx6FhhKHKfyZ58WO0JoDFOnfZAKmhVjd5ThsRmPFbX987pHqOhJd4zFP8IIfVnPKn3ZgvJEGkVZIFvTkEBgzj9VTuXe+rbF24SjepKOCGJug8emT2rW6kFFwUsWAB3ckTGFiM8NL7lEZXyFn9zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=rQdB9MRT; arc=none smtp.client-ip=142.132.176.110 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="rQdB9MRT" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPA id 5BBD740F30; Tue, 16 Jun 2026 21:10:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=dkim; t=1781637009; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=z8uQcTpVa5mUFmeEmrbH/dNU63tBNszSpBUJcWOlSZA=; b=rQdB9MRTtC7FWJ/w+93hNdZfyzpDvupX/0vN3mqYNs66IDLdjy1NX9pu63cHY6d+ZZ0t7e 0rbzR+04IaNu1gA0bjRaGsKROPhGyV4eCByyA/AnCveeaPzfzzndQNWdt7Kk5Jpyl/2DGg 12D3QHdk8T3vFpNpMtpVE4Ayx1CJSOtZ6BG8yEghg9XW45JVfxfybxxQADQLIEsIA+J8ge 0tynwuj5HZOIZ8tQIPQyRl4Y13dkpQWp/2L+eocEwOoyAiyXAji8O/ybNBjQHJImW0Y3rN XrhukNqAzprIfPCUhLZg13OtLceDKppzzo7s4LjrG/DNbNRZk2/jiO4RlI6CTg== From: "Dragan Simic" In-Reply-To: <7421df7a7b7778ee99363cccfdfabbfa8aa6ab5e.1781622998.git.geraldogabriel@gmail.com> Content-Type: text/plain; charset="utf-8" References: <7421df7a7b7778ee99363cccfdfabbfa8aa6ab5e.1781622998.git.geraldogabriel@gmail.com> Date: Tue, 16 Jun 2026 21:10:08 +0200 Cc: "Shawn Lin" , linux-rockchip@lists.infradead.org, "Lorenzo Pieralisi" , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , "Manivannan Sadhasivam" , "Rob Herring" , "Bjorn Helgaas" , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: "Geraldo Nascimento" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <153da5a0-7d58-4e0e-6700-432e401c9048@manjaro.org> Subject: =?utf-8?q?Re=3A?= [PATCH v7 3/3] =?utf-8?q?PCI=3A?==?utf-8?q?_rockchip=3A?= drive at =?utf-8?q?2=2E5?==?utf-8?q?_GT/s=2C?= error other speeds User-Agent: SOGoMail 5.12.3 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: None Hello Geraldo, Thanks for the v6 and v7 of this series. On Tuesday, June 16, 2026 17:26 CEST, Geraldo Nascimento wrote: > Configure the core to be driven at 2.5 GT/s Link Speed and ignore > any other speed with a warning. Also drop the 5.0 GT/s Link Speed > defines from Rockchip PCIe header. >=20 > The reason is that Shawn Lin from Rockchip has reiterated that there > may be danger of "catastrophic failure" in using their PCIe with > 5.0 GT/s speeds. >=20 > While Rockchip has done so informally without issuing a proper errata= , > and the particulars are thus unknown, this may cause data loss or > worse. >=20 > This change is corroborated by RK3399 official datasheet [1], which > states maximum link speed for this platform is 2.5 GT/s. >=20 > [1] https://opensource.rock-chips.com/images/d/d7/Rockchip=5FRK3399=5F= Datasheet=5FV2.1-20200323.pdf >=20 > Fixes: 956cd99b35a8 ("PCI: rockchip: Separate common code from RC dri= ver") > Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21= b@rock-chips.com/ > Cc: stable@vger.kernel.org > Reported-by: Dragan Simic > Reported-by: Shawn Lin > Signed-off-by: Geraldo Nascimento > --- > drivers/pci/controller/pcie-rockchip.c | 14 ++++++-------- > drivers/pci/controller/pcie-rockchip.h | 3 --- > 2 files changed, 6 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/con= troller/pcie-rockchip.c > index 0f88da3788054..456dcfd676ed7 100644 > --- a/drivers/pci/controller/pcie-rockchip.c > +++ b/drivers/pci/controller/pcie-rockchip.c > @@ -66,8 +66,10 @@ int rockchip=5Fpcie=5Fparse=5Fdt(struct rockchip=5F= pcie *rockchip) > } > =20 > rockchip->link=5Fgen =3D of=5Fpci=5Fget=5Fmax=5Flink=5Fspeed(node); > - if (rockchip->link=5Fgen < 0 || rockchip->link=5Fgen > 2) > - rockchip->link=5Fgen =3D 2; > + if (rockchip->link=5Fgen < 0 || rockchip->link=5Fgen >=3D 2) { > + rockchip->link=5Fgen =3D 1; > + dev=5Fwarn(dev, "invalid max-link-speed, limited to 2.5 GT/s\n"); > + } > =20 > for (i =3D 0; i < ROCKCHIP=5FNUM=5FPM=5FRSTS; i++) > rockchip->pm=5Frsts[i].id =3D rockchip=5Fpci=5Fpm=5Frsts[i]; > @@ -147,12 +149,8 @@ int rockchip=5Fpcie=5Finit=5Fport(struct rockchi= p=5Fpcie *rockchip) > goto err=5Fexit=5Fphy; > } > =20 > - if (rockchip->link=5Fgen =3D=3D 2) > - rockchip=5Fpcie=5Fwrite(rockchip, PCIE=5FCLIENT=5FGEN=5FSEL=5F2, > - PCIE=5FCLIENT=5FCONFIG); > - else > - rockchip=5Fpcie=5Fwrite(rockchip, PCIE=5FCLIENT=5FGEN=5FSEL=5F1, > - PCIE=5FCLIENT=5FCONFIG); > + rockchip=5Fpcie=5Fwrite(rockchip, PCIE=5FCLIENT=5FGEN=5FSEL=5F1, > + PCIE=5FCLIENT=5FCONFIG); > =20 > regs =3D PCIE=5FCLIENT=5FARI=5FENABLE | > PCIE=5FCLIENT=5FCONF=5FLANE=5FNUM(rockchip->lanes); > diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/con= troller/pcie-rockchip.h > index 3e82a69b9c006..b5da15601b585 100644 > --- a/drivers/pci/controller/pcie-rockchip.h > +++ b/drivers/pci/controller/pcie-rockchip.h > @@ -42,7 +42,6 @@ > #define PCIE=5FCLIENT=5FMODE=5FRC HWORD=5FSET=5FBIT(0x0040) > #define PCIE=5FCLIENT=5FMODE=5FEP HWORD=5FCLR=5FBIT(0x0040) > #define PCIE=5FCLIENT=5FGEN=5FSEL=5F1 HWORD=5FCLR=5FBIT(0x0080) > -#define PCIE=5FCLIENT=5FGEN=5FSEL=5F2 HWORD=5FSET=5FBIT(0x0080) > #define PCIE=5FCLIENT=5FLEGACY=5FINT=5FCTRL (PCIE=5FCLIENT=5FBASE + = 0x0c) > #define PCIE=5FCLIENT=5FINT=5FIN=5FASSERT HWORD=5FSET=5FBIT(0x000= 2) > #define PCIE=5FCLIENT=5FINT=5FIN=5FDEASSERT HWORD=5FCLR=5FBIT(0x0= 002) > @@ -197,8 +196,6 @@ > (((x) & PCIE=5FCORE=5FPL=5FCONF=5FLS=5FMASK) =3D=3D PCIE=5FCORE=5FP= L=5FCONF=5FLS=5FREADY) > #define PCIE=5FLINK=5FUP(x) \ > (((x) & PCIE=5FCLIENT=5FLINK=5FSTATUS=5FMASK) =3D=3D PCIE=5FCLIENT=5F= LINK=5FSTATUS=5FUP) > -#define PCIE=5FLINK=5FIS=5FGEN2(x) \ > - (((x) & PCIE=5FCORE=5FPL=5FCONF=5FSPEED=5FMASK) =3D=3D PCIE=5FCORE=5F= PL=5FCONF=5FSPEED=5F5G) > =20 > #define RC=5FREGION=5F0=5FADDR=5FTRANS=5FH 0x00000000 > #define RC=5FREGION=5F0=5FADDR=5FTRANS=5FL 0x00000000 Looking good to me, so please feel free to include Reviewed-by: Dragan Simic