From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2042C433F5 for ; Mon, 18 Oct 2021 18:52:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8765860E97 for ; Mon, 18 Oct 2021 18:52:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232306AbhJRSyz (ORCPT ); Mon, 18 Oct 2021 14:54:55 -0400 Received: from relay.sw.ru ([185.231.240.75]:41446 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbhJRSyx (ORCPT ); Mon, 18 Oct 2021 14:54:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:From: Subject; bh=FPgXvNFflId9yCiSM6OEGXB6bm9D5jdYlM4GUOjXptc=; b=v/v1+2RL7th4TFOnM fhrDxDe2acIKqtpc/j7V0VI1fVrBkbj21s8dd4LheDZScQgLdKmtYflcsRXLsjWd3tzBQ1U9m2TeO eV2Mmz3edrVXgCbJNvm61m/GG3jhpXKbRcQ8HtGkJsUa8m4paFL9LstT16cvS9/g0lYMfLTwK/bBo =; Received: from [172.29.1.17] by relay.sw.ru with esmtp (Exim 4.94.2) (envelope-from ) id 1mcXkS-006OdK-EG; Mon, 18 Oct 2021 21:52:36 +0300 Subject: Re: [PATCH memcg 0/1] false global OOM triggered by memcg-limited task To: Shakeel Butt , Michal Hocko Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Mel Gorman , Cgroups , Linux MM , LKML , kernel@openvz.org References: <9d10df01-0127-fb40-81c3-cc53c9733c3e@virtuozzo.com> <6b751abe-aa52-d1d8-2631-ec471975cc3a@virtuozzo.com> <27dc0c49-a0d6-875b-49c6-0ef5c0cc3ac8@virtuozzo.com> From: Vasily Averin Message-ID: <153f7aa6-39ef-f064-8745-a9489e088239@virtuozzo.com> Date: Mon, 18 Oct 2021 21:52:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.10.2021 18:07, Shakeel Butt wrote: > On Mon, Oct 18, 2021 at 5:27 AM Michal Hocko wrote: >> >> [restore the cc list] >> >> On Mon 18-10-21 15:14:26, Vasily Averin wrote: >>> On 18.10.2021 14:53, Michal Hocko wrote: >>>> On Mon 18-10-21 13:05:35, Vasily Averin wrote: >>>>> On 18.10.2021 12:04, Michal Hocko wrote: >>>>> Here we call try_charge_memcg() that return success and approve the allocation, >>>>> however then we hit into kmem limit and fail the allocation. >>>> >>>> Just to make sure I understand this would be for the v1 kmem explicit >>>> limit, correct? >>> >>> yes, I mean this limit. >> >> OK, thanks for the clarification. This is a known problem. Have a look >> at I think we consider that one to 0158115f702b ("memcg, kmem: deprecate >> kmem.limit_in_bytes"). We are reporting the deprecated and to-be removed >> status since 2019 without any actual report sugested by the kernel >> message. Maybe we should try and remove it and see whether that prompts >> some pushback. >> > > Yes, I think now should be the right time to take the next step for > deprecation of kmem limits: > https://lore.kernel.org/all/20201118175726.2453120-1-shakeelb@google.com/ Are you going to push it to stable kernels too? Thank you, Vasily Averin