Re: 2.5.2-pre7 still missing bits of kdev_t

[Nikita Danilov <Nikita@Namesys.COM>]

Linus Torvalds writes:
 > 
 > On Fri, 4 Jan 2002, Jeff Garzik wrote:
 > > >
 > > > Now, if somebody actually has the raw "kdev_t" in their on-disk
 > > > structures, that's a real problem, but I don't think anybody does.
 > > > Certainly I didn't see reiserfs do it (but it may well be missing a few
 > > > "kdev_t_to_nr()" calls)
 > >
 > > AFAICS it does:
 > >
 > > include/linux/reiserfs.h:
 > > #define sd_v1_rdev(sdp)         (le32_to_cpu((sdp)->u.sd_rdev))
 > > #define set_sd_v1_rdev(sdp,v)   ((sdp)->u.sd_rdev = cpu_to_le32(v))
 > 
 > Ok, just add the proper conversion functions, ie a "to_kdev_t()" and
 > "kdev_t_to_nr()".

Actually, result of sd_v1_rdev() is only passed to init_special_inode()
which takes int rather than kdev_t.

Isn't this a bit strange, because file system backend has to convert
kdev_t to u32 on write, but not on read?

 > 
 > 		Linus

Nikita.

 >