mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peng Hao <peng.hao2@zte.com.cn>
To: robh+dt@kernel.org, mark.rutland@arm.com, arnd@arndb.de,
	gregkh@linuxfoundation.org, andy@infradead.org,
	dvhart@infradead.org
Cc: linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, hutao@cn.fujitsu.com,
	linux-doc@vger.kernel.org, Peng Hao <peng.hao2@zte.com.cn>
Subject: [PATCH V8 03/11]  misc/pvpanic: add MMIO support
Date: Tue, 6 Nov 2018 22:57:14 +0800	[thread overview]
Message-ID: <1541516242-98568-3-git-send-email-peng.hao2@zte.com.cn> (raw)
In-Reply-To: <1541516242-98568-1-git-send-email-peng.hao2@zte.com.cn>

On some architectures (e.g. arm64), it's preferable to use MMIO, since
this can be used standalone. Add MMIO support to the pvpanic driver.

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
[Use acpi_dev_resource_memory API. - Andy]
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 drivers/misc/pvpanic.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 49c59e1..e923dac 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpanic.c
@@ -26,6 +26,8 @@
 #include <linux/types.h>
 #include <linux/acpi.h>
 
+static void __iomem *base;
+
 MODULE_AUTHOR("Hu Tao <hutao@cn.fujitsu.com>");
 MODULE_DESCRIPTION("pvpanic device driver");
 MODULE_LICENSE("GPL");
@@ -41,8 +43,6 @@
 
 #define PVPANIC_PANICKED	(1 << 0)
 
-static u16 port;
-
 static struct acpi_driver pvpanic_driver = {
 	.name =		"pvpanic",
 	.class =	"QEMU",
@@ -57,7 +57,7 @@
 static void
 pvpanic_send_event(unsigned int event)
 {
-	outb(event, port);
+	iowrite8(event, base);
 }
 
 static int
@@ -80,7 +80,10 @@
 	struct resource r;
 
 	if (acpi_dev_resource_io(res, &r)) {
-		port = r.start;
+		base = ioport_map(r.start, resource_size(&r));
+		return AE_OK;
+	} else if (acpi_dev_resource_memory(res, &r)) {
+		base = ioremap(r.start, resource_size(&r));
 		return AE_OK;
 	}
 
@@ -101,7 +104,7 @@ static int pvpanic_add(struct acpi_device *device)
 	acpi_walk_resources(device->handle, METHOD_NAME__CRS,
 			    pvpanic_walk_resources, NULL);
 
-	if (!port)
+	if (!base)
 		return -ENODEV;
 
 	atomic_notifier_chain_register(&panic_notifier_list,
@@ -115,6 +118,8 @@ static int pvpanic_remove(struct acpi_device *device)
 
 	atomic_notifier_chain_unregister(&panic_notifier_list,
 					 &pvpanic_panic_nb);
+	iounmap(base);
+
 	return 0;
 }
 
-- 
1.8.3.1


  parent reply	other threads:[~2018-11-06  6:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 14:57 [PATCH V8 01/11] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-11-06 14:57 ` [PATCH v8 02/11] misc/pvpanic: simplify the code using acpi_dev_resource_io Peng Hao
2018-11-06 14:57 ` Peng Hao [this message]
2018-11-06 14:57 ` [PATCH V8 04/11] dt-bindings: misc/pvpanic: add document for pvpanic-mmio Peng Hao
2018-11-06 14:57 ` [PATCH V8 05/11] misc/pvpanic: add support to get pvpanic device info FDT Peng Hao
2018-11-06 14:57 ` [PATCH V8 06/11] misc/pvpanic : grouping ACPI related stuff Peng Hao
2018-11-06 14:57 ` [PATCH V8 07/11] misc/pvpanic : break dependency on ACPI Peng Hao
2018-11-06 14:57 ` [PATCH V8 08/11] misc/pvpanic: remove unnecessary header file Peng Hao
2018-11-06 14:57 ` [PATCH V8 09/11] misc/pvpanic: change header file sort style Peng Hao
2018-11-06 10:02   ` Andy Shevchenko
2018-11-06 14:57 ` [PATCH V8 10/11] misc/pvpanic: convert to SPDX license tags Peng Hao
2018-11-06 14:57 ` [PATCH V8 11/11] misc/pvpanic: remove a redundant comma Peng Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541516242-98568-3-git-send-email-peng.hao2@zte.com.cn \
    --to=peng.hao2@zte.com.cn \
    --cc=andy@infradead.org \
    --cc=arnd@arndb.de \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hutao@cn.fujitsu.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®