mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: miklos@szeredi.hu, ktkhai@virtuozzo.com,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/5] fuse: Kill fasync only if interrupt is queued in queue_interrupt()
Date: Thu, 08 Nov 2018 12:05:20 +0300	[thread overview]
Message-ID: <154166792021.10655.6752271937511795324.stgit@localhost.localdomain> (raw)
In-Reply-To: <154166765576.10655.15178401490817622677.stgit@localhost.localdomain>

We should sent signal only in case of interrupt is really queued.
Not a real problem, but this makes the code clearer and intuitive.

v2: Move kill_fasync() under fiq->waitq.lock

Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
 fs/fuse/dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index ae813e609932..1ecec7fcb841 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -476,9 +476,9 @@ static void queue_interrupt(struct fuse_iqueue *fiq, struct fuse_req *req)
 	if (list_empty(&req->intr_entry)) {
 		list_add_tail(&req->intr_entry, &fiq->interrupts);
 		wake_up_locked(&fiq->waitq);
+		kill_fasync(&fiq->fasync, SIGIO, POLL_IN);
 	}
 	spin_unlock(&fiq->waitq.lock);
-	kill_fasync(&fiq->fasync, SIGIO, POLL_IN);
 }
 
 static void request_wait_answer(struct fuse_conn *fc, struct fuse_req *req)


  reply	other threads:[~2018-11-08  9:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08  9:05 [PATCH v2 0/5] fuse: Interrupt-related optimizations and improvements Kirill Tkhai
2018-11-08  9:05 ` Kirill Tkhai [this message]
2018-11-08  9:05 ` [PATCH v2 2/5] fuse: Optimize request_end() by not taking fiq->waitq.lock Kirill Tkhai
2018-11-08  9:05 ` [PATCH v2 3/5] fuse: Wake up req->waitq of only not background requests in request_end() Kirill Tkhai
2018-11-08  9:05 ` [PATCH v2 4/5] fuse: Do some refactoring in fuse_dev_do_write() Kirill Tkhai
2018-11-08  9:05 ` [PATCH v2 5/5] fuse: Verify userspace asks to requeue interrupt that we really sent Kirill Tkhai
2018-12-26 13:25 ` [PATCH v2 0/5] fuse: Interrupt-related optimizations and improvements Kirill Tkhai
2019-01-10  8:37   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154166792021.10655.6752271937511795324.stgit@localhost.localdomain \
    --to=ktkhai@virtuozzo.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®