From: Stephen Boyd <sboyd@kernel.org>
To: Yi Wang <wang.yi59@zte.com.cn>, paul.burton@mips.com
Cc: mturquette@baylibre.com, linux-mips@linux-mips.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
zhong.weidong@zte.com.cn, Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [PATCH v3 1/2] clk: boston: fix possible memory leak in clk_boston_setup()
Date: Thu, 08 Nov 2018 10:19:29 -0800 [thread overview]
Message-ID: <154170116960.88331.164103375264551287@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1540971702-3133-2-git-send-email-wang.yi59@zte.com.cn>
Quoting Yi Wang (2018-10-31 00:41:41)
> Smatch report warnings:
> drivers/clk/imgtec/clk-boston.c:76 clk_boston_setup() warn: possible memory leak of 'onecell'
> drivers/clk/imgtec/clk-boston.c:83 clk_boston_setup() warn: possible memory leak of 'onecell'
> drivers/clk/imgtec/clk-boston.c:90 clk_boston_setup() warn: possible memory leak of 'onecell'
>
> 'onecell' is malloced in clk_boston_setup(), but not be freed
> before leaving from the error handling cases.
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> ---
Applied to clk-next
next prev parent reply other threads:[~2018-11-08 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 7:41 [PATCH v3 0/2] fix memory leak and unregister issue " Yi Wang
2018-10-31 7:41 ` [PATCH v3 1/2] clk: boston: fix possible memory leak " Yi Wang
2018-11-08 18:19 ` Stephen Boyd [this message]
2018-10-31 7:41 ` [PATCH v3 2/2] clk: boston: unregister clks on failure " Yi Wang
2018-11-08 18:19 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154170116960.88331.164103375264551287@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mturquette@baylibre.com \
--cc=paul.burton@mips.com \
--cc=wang.yi59@zte.com.cn \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®