mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org
Cc: Richard Weinberger <richard@sigma-star.at>,
	linuxppc-dev@lists.ozlabs.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC
Date: Mon, 12 Nov 2018 11:35:19 +0900	[thread overview]
Message-ID: <1541990120-9643-2-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1541990120-9643-1-git-send-email-yamada.masahiro@socionext.com>

Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.

'$(call cc-option,-fno-unit-at-a-time)' is now dead code since
'$(cc-version) -lt 0400' is always false.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/x86/Makefile.um | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um
index 91085a0..577976b 100644
--- a/arch/x86/Makefile.um
+++ b/arch/x86/Makefile.um
@@ -26,12 +26,8 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2)
 # an unresolved reference.
 cflags-y += -ffreestanding
 
-# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
-# a lot more stack due to the lack of sharing of stacklots.  Also, gcc
-# 4.3.0 needs -funit-at-a-time for extern inline functions.
-KBUILD_CFLAGS += $(shell if [ $(cc-version) -lt 0400 ] ; then \
-			echo $(call cc-option,-fno-unit-at-a-time); \
-			else echo $(call cc-option,-funit-at-a-time); fi ;)
+# gcc 4.3.0 needs -funit-at-a-time for extern inline functions.
+KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time)
 
 KBUILD_CFLAGS += $(cflags-y)
 
-- 
2.7.4


  reply	other threads:[~2018-11-12  2:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  2:35 [PATCH 0/2] Remove -fno-unit-at-a-time and -funit-at-a-time compiler flags entirely Masahiro Yamada
2018-11-12  2:35 ` Masahiro Yamada [this message]
2018-11-13  9:47   ` [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC Richard Weinberger
2018-12-08  6:35     ` Masahiro Yamada
2018-12-08  8:54       ` Richard Weinberger
2018-12-08 19:18         ` Masahiro Yamada
2018-12-09 11:06   ` [tip:x86/build] x86/um: Remove " tip-bot for Masahiro Yamada
2018-11-12  2:35 ` [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely Masahiro Yamada
2018-11-12  3:01   ` Ingo Molnar
2018-11-12 11:22   ` Michael Ellerman
2018-12-08  6:36     ` Masahiro Yamada
2018-12-08 11:33       ` Borislav Petkov
2018-12-08 19:17         ` Masahiro Yamada
2018-12-09 11:07   ` [tip:x86/build] x86, powerpc: Remove " tip-bot for Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541990120-9643-2-git-send-email-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=richard@sigma-star.at \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®