From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA3AC43441 for ; Fri, 16 Nov 2018 10:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E9AD208E3 for ; Fri, 16 Nov 2018 10:15:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E9AD208E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389566AbeKPU11 (ORCPT ); Fri, 16 Nov 2018 15:27:27 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:46713 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727393AbeKPU11 (ORCPT ); Fri, 16 Nov 2018 15:27:27 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gNb9i-0005tf-G5; Fri, 16 Nov 2018 11:15:18 +0100 Message-ID: <1542363310.23489.22.camel@pengutronix.de> Subject: Re: [PATCH 3/9] drm: replace "drm_dev_unref" function with "drm_dev_put" From: Lucas Stach To: Fernando Ramos , dri-devel@lists.freedesktop.org Cc: David Airlie , Maarten Lankhorst , Maxime Ripard , Sean Paul , Jonathan Corbet , Alexey Brodkin , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Gerd Hoffmann , Archit Taneja , Andrzej Hajda , Laurent Pinchart , Russell King , Christian Gmeiner , Marek Vasut , Stefan Agner , Kieran Bingham , Linus Walleij , Shawn Guo , Julia Lawall , Gilles Muller , Nicolas Palix , Michal Marek , Haneen Mohammed , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, etnaviv@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, cocci@systeme.lip6.fr Date: Fri, 16 Nov 2018 11:15:10 +0100 In-Reply-To: <20181115221634.22715-4-greenfoo@gluegarage.com> References: <20181115221634.22715-1-greenfoo@gluegarage.com> <20181115221634.22715-4-greenfoo@gluegarage.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 15.11.2018, 23:16 +0100 schrieb Fernando Ramos: > This patch unifies the naming of DRM functions for reference counting as > requested on Documentation/gpu/todo.rst > > > Signed-off-by: Fernando Ramos > --- >  drivers/gpu/drm/arc/arcpgu_drv.c             | 4 ++-- >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- >  drivers/gpu/drm/etnaviv/etnaviv_drv.c        | 4 ++-- At least the etnaviv part of the patch is already fixed in linux-next. Regards, Lucas >  drivers/gpu/drm/mxsfb/mxsfb_drv.c            | 4 ++-- >  drivers/gpu/drm/rcar-du/rcar_du_drv.c        | 2 +- >  drivers/gpu/drm/shmobile/shmob_drm_drv.c     | 4 ++-- >  drivers/gpu/drm/tve200/tve200_drv.c          | 4 ++-- >  drivers/gpu/drm/zte/zx_drm_drv.c             | 4 ++-- >  8 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c > index f067de4e1e82..dcb06d4e9135 100644 > --- a/drivers/gpu/drm/arc/arcpgu_drv.c > +++ b/drivers/gpu/drm/arc/arcpgu_drv.c > @@ -216,7 +216,7 @@ static int arcpgu_probe(struct platform_device *pdev) > >   arcpgu_unload(drm); >   >  err_unref: > > - drm_dev_unref(drm); > > + drm_dev_put(drm); >   > >   return ret; >  } > @@ -227,7 +227,7 @@ static int arcpgu_remove(struct platform_device *pdev) >   > >   drm_dev_unregister(drm); > >   arcpgu_unload(drm); > > - drm_dev_unref(drm); > > + drm_dev_put(drm); >   > >   return 0; >  } > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > index 843cac222e60..f8da51a63e2f 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -775,7 +775,7 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) > >   atmel_hlcdc_dc_unload(ddev); >   >  err_unref: > > - drm_dev_unref(ddev); > > + drm_dev_put(ddev); >   > >   return ret; >  } > @@ -786,7 +786,7 @@ static int atmel_hlcdc_dc_drm_remove(struct platform_device *pdev) >   > >   drm_dev_unregister(ddev); > >   atmel_hlcdc_dc_unload(ddev); > > - drm_dev_unref(ddev); > > + drm_dev_put(ddev); >   > >   return 0; >  } > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > index 83c1f46670bf..52802e6049e0 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > @@ -550,7 +550,7 @@ static int etnaviv_bind(struct device *dev) >  out_bind: > >   kfree(priv); >  out_unref: > > - drm_dev_unref(drm); > > + drm_dev_put(drm); >   > >   return ret; >  } > @@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev) > >   drm->dev_private = NULL; > >   kfree(priv); >   > > - drm_dev_unref(drm); > > + drm_dev_put(drm); >  } >   >  static const struct component_master_ops etnaviv_master_ops = { > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index 2393e6d16ffd..88ba003979e6 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -417,7 +417,7 @@ static int mxsfb_probe(struct platform_device *pdev) >  err_unload: > >   mxsfb_unload(drm); >  err_free: > > - drm_dev_unref(drm); > > + drm_dev_put(drm); >   > >   return ret; >  } > @@ -428,7 +428,7 @@ static int mxsfb_remove(struct platform_device *pdev) >   > >   drm_dev_unregister(drm); > >   mxsfb_unload(drm); > > - drm_dev_unref(drm); > > + drm_dev_put(drm); >   > >   return 0; >  } > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 084f58df4a8c..c7fe2433ab9e 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -454,7 +454,7 @@ static int rcar_du_remove(struct platform_device *pdev) > >   drm_kms_helper_poll_fini(ddev); > >   drm_mode_config_cleanup(ddev); >   > > - drm_dev_unref(ddev); > > + drm_dev_put(ddev); >   > >   return 0; >  } > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > index 6ececad6f845..8554102a6ead 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device *pdev) > >   drm_kms_helper_poll_fini(ddev); > >   drm_mode_config_cleanup(ddev); > >   drm_irq_uninstall(ddev); > > - drm_dev_unref(ddev); > > + drm_dev_put(ddev); >   > >   return 0; >  } > @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device *pdev) > >   drm_kms_helper_poll_fini(ddev); > >   drm_mode_config_cleanup(ddev); >  err_free_drm_dev: > > - drm_dev_unref(ddev); > > + drm_dev_put(ddev); >   > >   return ret; >  } > diff --git a/drivers/gpu/drm/tve200/tve200_drv.c b/drivers/gpu/drm/tve200/tve200_drv.c > index 72efcecb44f7..28e2d03c0ccf 100644 > --- a/drivers/gpu/drm/tve200/tve200_drv.c > +++ b/drivers/gpu/drm/tve200/tve200_drv.c > @@ -249,7 +249,7 @@ static int tve200_probe(struct platform_device *pdev) >  clk_disable: > >   clk_disable_unprepare(priv->pclk); >  dev_unref: > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > >   return ret; >  } >   > @@ -263,7 +263,7 @@ static int tve200_remove(struct platform_device *pdev) > >   drm_panel_bridge_remove(priv->bridge); > >   drm_mode_config_cleanup(drm); > >   clk_disable_unprepare(priv->pclk); > > - drm_dev_unref(drm); > > + drm_dev_put(drm); >   > >   return 0; >  } > diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c > index 11ef17c2d1c1..5b6f1eda52e0 100644 > --- a/drivers/gpu/drm/zte/zx_drm_drv.c > +++ b/drivers/gpu/drm/zte/zx_drm_drv.c > @@ -114,7 +114,7 @@ static int zx_drm_bind(struct device *dev) > >   component_unbind_all(dev, drm); >  out_unregister: > >   dev_set_drvdata(dev, NULL); > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > >   return ret; >  } >   > @@ -127,7 +127,7 @@ static void zx_drm_unbind(struct device *dev) > >   drm_mode_config_cleanup(drm); > >   component_unbind_all(dev, drm); > >   dev_set_drvdata(dev, NULL); > > - drm_dev_unref(drm); > > + drm_dev_put(drm); >  } >   >  static const struct component_master_ops zx_drm_master_ops = {