From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: marcelo@conectiva.com.br
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.4.18-pre4 bonding driver...
Date: Thu, 17 Jan 2002 22:15:00 +0100 [thread overview]
Message-ID: <15431.16084.190369.177282@charged.uio.no> (raw)
In-Reply-To: <200201162351.AAA24092@webserver.ithnet.com>
In-Reply-To: <15430.2169.508178.665820@charged.uio.no> <200201162351.AAA24092@webserver.ithnet.com>
Marcelo,
Is this code from linux-2.4.18-pre4/drivers/net/bonding.c safe?
static int bond_close(struct net_device *master)
{
write_lock_irqsave(&bond->lock, flags);
<snip>
bond_release_all(master);
write_unlock_irqrestore(&bond->lock, flags);
AFAICS 'bond_release_all()' calls a bunch of lower level networking
functions some of which do sleep. It does nothing to release the
bond->lock when this occurs.
Cheers,
Trond
next parent reply other threads:[~2002-01-17 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200201162351.AAA24092@webserver.ithnet.com>
[not found] ` <15430.2169.508178.665820@charged.uio.no>
2002-01-17 21:15 ` Trond Myklebust [this message]
2002-01-21 18:37 ` Marcelo Tosatti
2002-01-17 21:39 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15431.16084.190369.177282@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®