From: Stephen Boyd <swboyd@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Ryan Case <ryandcase@chromium.org>
Cc: Evan Green <evgreen@chromium.org>,
Doug Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Ryan Case <ryandcase@chromium.org>
Subject: Re: [PATCH v3] tty: serial: qcom_geni_serial: Fix softlock
Date: Mon, 03 Dec 2018 08:22:15 -0800 [thread overview]
Message-ID: <154385413596.88331.2252934244242692154@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181130021840.75861-1-ryandcase@chromium.org>
Quoting Ryan Case (2018-11-29 18:18:40)
> Transfers were being divided into device FIFO sized (64 byte max)
> operations which would poll for completion within a spin_lock_irqsave /
> spin_unlock_irqrestore block. This both made things slow by waiting for
> the FIFO to completely drain before adding further data and would also
> result in softlocks on large transmissions.
>
> This patch allows larger transfers with continuous FIFO additions as
> space becomes available and removes polling from the interrupt handler.
>
> Signed-off-by: Ryan Case <ryandcase@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
prev parent reply other threads:[~2018-12-03 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 2:18 Ryan Case
2018-11-30 2:22 ` Doug Anderson
2018-12-03 16:22 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154385413596.88331.2252934244242692154@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ryandcase@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®