From: Firoz Khan <firoz.khan@linaro.org>
To: linux-mips@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>
Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, arnd@arndb.de,
deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org,
firoz.khan@linaro.org
Subject: [PATCH v4 1/7] mips: add __NR_syscalls along with __NR_Linux_syscalls
Date: Thu, 6 Dec 2018 10:48:22 +0530 [thread overview]
Message-ID: <1544073508-13720-2-git-send-email-firoz.khan@linaro.org> (raw)
In-Reply-To: <1544073508-13720-1-git-send-email-firoz.khan@linaro.org>
__NR_Linux_syscalls macro holds the number of system call
exist in mips architecture. We have to change the value of
__NR_Linux_syscalls, if we add or delete a system call.
One of the patch in this patch series has a script which
will generate a uapi header based on syscall.tbl file.
The syscall.tbl file contains the total number of system
calls information. So we have two option to update __NR-
_Linux_syscalls value.
1. Update __NR_Linux_syscalls in asm/unistd.h manually
by counting the no.of system calls. No need to update
__NR_Linux_syscalls until we either add a new system
call or delete existing system call.
2. We can keep this feature it above mentioned script,
that will count the number of syscalls and keep it in
a generated file. In this case we don't need to expli-
citly update __NR_Linux_syscalls in asm/unistd.h file.
The 2nd option will be the recommended one. For that, I
added the __NR_syscalls macro in uapi/asm/unistd.h along
with __NR_Linux_syscalls. The macro __NR_syscalls also
added for making the name convention same across all
architecture. While __NR_syscalls isn't strictly part of
the uapi, having it as part of the generated header to
simplifies the implementation. We also need to enclose
this macro with #ifdef __KERNEL__ to avoid side effects.
Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
---
arch/mips/include/uapi/asm/unistd.h | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/arch/mips/include/uapi/asm/unistd.h b/arch/mips/include/uapi/asm/unistd.h
index f25dd1d..6914be5 100644
--- a/arch/mips/include/uapi/asm/unistd.h
+++ b/arch/mips/include/uapi/asm/unistd.h
@@ -391,11 +391,14 @@
#define __NR_rseq (__NR_Linux + 367)
#define __NR_io_pgetevents (__NR_Linux + 368)
+#ifdef __KERNEL__
+#define __NR_syscalls 368
+#endif
/*
* Offset of the last Linux o32 flavoured syscall
*/
-#define __NR_Linux_syscalls 368
+#define __NR_Linux_syscalls __NR_syscalls
#endif /* _MIPS_SIM == _MIPS_SIM_ABI32 */
@@ -738,10 +741,14 @@
#define __NR_rseq (__NR_Linux + 327)
#define __NR_io_pgetevents (__NR_Linux + 328)
+#ifdef __KERNEL__
+#define __NR_syscalls 328
+#endif
+
/*
* Offset of the last Linux 64-bit flavoured syscall
*/
-#define __NR_Linux_syscalls 328
+#define __NR_Linux_syscalls __NR_syscalls
#endif /* _MIPS_SIM == _MIPS_SIM_ABI64 */
@@ -1088,10 +1095,14 @@
#define __NR_rseq (__NR_Linux + 331)
#define __NR_io_pgetevents (__NR_Linux + 332)
+#ifdef __KERNEL__
+#define __NR_syscalls 332
+#endif
+
/*
* Offset of the last N32 flavoured syscall
*/
-#define __NR_Linux_syscalls 332
+#define __NR_Linux_syscalls __NR_syscalls
#endif /* _MIPS_SIM == _MIPS_SIM_NABI32 */
--
1.9.1
next prev parent reply other threads:[~2018-12-06 5:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 5:18 [PATCH v4 0/7] mips: system call table generation support Firoz Khan
2018-12-06 5:18 ` Firoz Khan [this message]
2018-12-06 5:18 ` [PATCH v4 2/7] mips: remove unused macros Firoz Khan
2018-12-06 5:18 ` [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64' Firoz Khan
2018-12-10 19:51 ` Paul Burton
2018-12-10 23:32 ` Maciej W. Rozycki
2018-12-10 23:46 ` Paul Burton
2018-12-11 10:58 ` Maciej W. Rozycki
2018-12-11 8:45 ` Firoz Khan
2018-12-11 18:59 ` Paul Burton
2018-12-12 4:34 ` Firoz Khan
2018-12-12 22:28 ` Paul Burton
2018-12-13 8:53 ` Firoz Khan
2018-12-13 20:15 ` Paul Burton
2018-12-14 5:50 ` Firoz Khan
2018-12-06 5:18 ` [PATCH v4 4/7] mips: add +1 to __NR_syscalls in uapi header Firoz Khan
2018-12-06 5:18 ` [PATCH v4 5/7] mips: remove syscall table entries Firoz Khan
2018-12-06 5:18 ` [PATCH v4 6/7] mips: add system call table generation support Firoz Khan
2018-12-06 5:18 ` [PATCH v4 7/7] mips: generate uapi header and system call table files Firoz Khan
2018-12-10 5:35 ` [PATCH v4 0/7] mips: system call table generation support Firoz Khan
2018-12-10 5:41 ` Paul Burton
2018-12-10 8:05 ` Firoz Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544073508-13720-2-git-send-email-firoz.khan@linaro.org \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhogan@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=paul.burton@mips.com \
--cc=pombredanne@nexb.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®