From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C08EC04EBF for ; Thu, 6 Dec 2018 11:10:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B8CF20850 for ; Thu, 6 Dec 2018 11:10:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B8CF20850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729624AbeLFLKy (ORCPT ); Thu, 6 Dec 2018 06:10:54 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41327 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727575AbeLFLKx (ORCPT ); Thu, 6 Dec 2018 06:10:53 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gUrYG-0003M3-AX; Thu, 06 Dec 2018 12:10:40 +0100 Message-ID: <1544094639.3709.58.camel@pengutronix.de> Subject: Re: [PATCH 1/5] irqchip/irq-imx-gpcv2: Remove unused code From: Lucas Stach To: Andrey Smirnov , Marc Zyngier Cc: Thomas Gleixner , Jason Cooper , cphealy@gmail.com, Leonard Crestez , "A.s. Dong" , Richard Zhu , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 06 Dec 2018 12:10:39 +0100 In-Reply-To: <20181206073125.7255-2-andrew.smirnov@gmail.com> References: <20181206073125.7255-1-andrew.smirnov@gmail.com> <20181206073125.7255-2-andrew.smirnov@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, den 05.12.2018, 23:31 -0800 schrieb Andrey Smirnov: > Varaible 'reg' in imx_gpcv2_irq_set_wake() has no users. Remove it. > > > Cc: Thomas Gleixner > > Cc: Jason Cooper > > Cc: Marc Zyngier > Cc: cphealy@gmail.com > Cc: l.stach@pengutronix.de > > Cc: Leonard Crestez > > Cc: "A.s. Dong" > > Cc: Richard Zhu > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach > --- >  drivers/irqchip/irq-imx-gpcv2.c | 2 -- >  1 file changed, 2 deletions(-) > > diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c > index 4760307ab43f..cbed00319315 100644 > --- a/drivers/irqchip/irq-imx-gpcv2.c > +++ b/drivers/irqchip/irq-imx-gpcv2.c > @@ -73,11 +73,9 @@ static int imx_gpcv2_irq_set_wake(struct irq_data *d, unsigned int on) > >   struct gpcv2_irqchip_data *cd = d->chip_data; > >   unsigned int idx = d->hwirq / 32; > >   unsigned long flags; > > - void __iomem *reg; > >   u32 mask, val; >   > >   raw_spin_lock_irqsave(&cd->rlock, flags); > > - reg = cd->gpc_base + cd->cpu2wakeup + idx * 4; > >   mask = 1 << d->hwirq % 32; > >   val = cd->wakeup_sources[idx]; >