From: David Garfield <garfield@irving.iisd.sra.com>
To: Robert Love <rml@tech9.net>
Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: [PATCH] add BUG_ON to 2.4 #2
Date: Fri, 25 Jan 2002 18:25:07 -0500 [thread overview]
Message-ID: <15441.59731.568087.579456@irving.iisd.sra.com> (raw)
In-Reply-To: <1012000599.3799.85.camel@phantasy>
In-Reply-To: <1012000599.3799.85.camel@phantasy>
Robert Love writes:
...
> diff -urN linux-2.4.18-pre7/mm/vmscan.c linux/mm/vmscan.c
> --- linux-2.4.18-pre7/mm/vmscan.c Thu Jan 24 13:48:18 2002
> +++ linux/mm/vmscan.c Fri Jan 25 18:05:14 2002
...
> @@ -354,10 +354,8 @@
>
> page = list_entry(entry, struct page, lru);
>
> - if (unlikely(!PageLRU(page)))
> - BUG();
> - if (unlikely(PageActive(page)))
> - BUG();
> + BUG_ON(unlikely(!PageLRU(page)));
> + BUG_ON(unlikely(PageActive(page)))
>
> list_del(entry);
> list_add(entry, &inactive_list);
>
While I don't know the exact definitions, this works out to:
if (unlikely(unlikely(!PageLRU(page)))) BUG();
which I doubt is a good idea.
--David Garfield
next prev parent reply other threads:[~2002-01-25 23:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-25 23:16 Robert Love
2002-01-25 23:25 ` David Garfield [this message]
2002-01-25 23:58 ` Robert Love
2002-01-25 23:57 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15441.59731.568087.579456@irving.iisd.sra.com \
--to=garfield@irving.iisd.sra.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®