From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751596AbcBUR53 (ORCPT ); Sun, 21 Feb 2016 12:57:29 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:45741 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbcBURxD (ORCPT ); Sun, 21 Feb 2016 12:53:03 -0500 From: Markus Pargmann To: Arnd Bergmann Cc: Lee Jones , linux-arm-kernel@lists.infradead.org, Denis Carikli , Juergen Borleis , Jonathan Cameron , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: fsl-imx25-tsadc: select IRQ_DOMAIN Date: Sun, 21 Feb 2016 14:07:15 +0100 Message-ID: <1544245.mjq7iKKDQ3@galactica> User-Agent: KMail/4.14.10 (Linux/4.4.0-trunk-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1455634467-2013548-1-git-send-email-arnd@arndb.de> References: <1455634467-2013548-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1459326.hTkEu3WQlY"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1459326.hTkEu3WQlY Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Tuesday 16 February 2016 15:54:24 Arnd Bergmann wrote: > The newly added tsadc code use irq domains, but it can be enabled > when they are disabled in Kconfig: >=20 > drivers/mfd/fsl-imx25-tsadc.c:41:22: error: implicit declaration of f= unction 'irq_find_mapping' [-Werror=3Dimplicit-function-declaration] > generic_handle_irq(irq_find_mapping(tsadc->domain, 1)); > drivers/mfd/fsl-imx25-tsadc.c: In function 'mx25_tsadc_setup_irq': > drivers/mfd/fsl-imx25-tsadc.c:80:18: error: implicit declaration of f= unction 'irq_domain_add_simple' [-Werror=3Dimplicit-function-declaratio= n] >=20 > This adds a 'select IRQ_DOMAIN' code, like we have it in all other > drivers with this requirement. >=20 > Signed-off-by: Arnd Bergmann > Fixes: e2fccf5c1515 ("mfd: fsl-imx25-tsadc: Register touchscreen ADC = driver") Thanks, Reviewed-by: Markus Pargmann Best Regards, Markus > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index aa21dc55eb15..8cab3ecca8fc 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -300,6 +300,7 @@ config MFD_MC13XXX_I2C > config MFD_MX25_TSADC > =09tristate "Freescale i.MX25 integrated Touchscreen and ADC unit" > =09select REGMAP_MMIO > +=09select IRQ_DOMAIN > =09depends on (SOC_IMX25 && OF) || COMPILE_TEST > =09help > =09 Enable support for the integrated Touchscreen and ADC unit of t= he >=20 =2D-=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 | --nextPart1459326.hTkEu3WQlY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWybaDAAoJECi9+rkzbKwyecgP/i8GTD72jFuB4pUA6KveRiln CbAA0MmTEM31TuHQH383shRNeorSWcPFrbwOeksLm79Zf4go+jklAAHE1WZpwqHj V8eI7ugePKRBI/k0AsCZtYDGBjX7YbZikvqQERqoqo/ZTJ7Z6eKDCPYhAPq3S06P 3pEU6DKydNJHr7LuVeR0vpu1fv6kVBjCdzS5TJn/WSqRS3B6y0AOSYVWBIHoYBgW 5z5eG/0SDSmJezDN072U0iD6oXv5Pg+QJ1ojee8fgVuJe4Q79zZCtBECbz0NZcaf LA8uNf3YZdafXDBjisTe9LSDgo/CDfDHxiZIu6Zy+OXNwMhgIJW8r7m+jbqhYP+0 /DscpVj2EJg3O0eI2iPRuNMG6APu6LJYAvMPF/u4ADqchjM8WSORLK+/UkpUfTjS NYgi30yZrA3VxjXgH8z9ZJvynU1CgEHnCfVm2SHnH+/vP8CMDMYZAuxEJyQceeza t/KPby5w98SLykYXDkuEYcIxKRiyW4jGOk9AHHCf8RgUl+ftlJLqPcr0BOV8DKpg y1MojhTTHMuDWH0ePbKzyfDC7LLcAu2ZaLeKUX8jSilZyvb+oMwZnshqZiJ/4sE8 Fftvrf658efeJbBWBViL4UjdfTfKZMByan/KjTVJRAMBR4exLpbLwQdGwO2VJ8lF rFCCmQNJ3Wb1bA2RTnm8 =KHQd -----END PGP SIGNATURE----- --nextPart1459326.hTkEu3WQlY--