mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
To: akpm@linux-foundation.org, linus@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [RFC PATCH] Don't reset timestamps in include/generated if not needed
Date: Tue, 03 Mar 2015 20:07:36 -0500	[thread overview]
Message-ID: <15447.1425431256@turing-police.cc.vt.edu> (raw)

Kbuild regenerates bounds.h and asm-offsets.h, resetting the timestamps
and forcing rebuilds even if the contents haven't changed.  Add a bit of
shell magic to only replace the file if the contents have in fact changed,
which should speed up git bisects and similar.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

---
So I was doing a git bisect, and getting towards the end, and wondering why
it's taking a long time for each build, and I notice that netfilter modules
are being rebuilt, even though 'git bisect visualize' doesn't show anything
that should have touched netfilter.  Turns out the offender is bounds.h

Fully 3/4 of my modules have a dependency on bounds.h - and we touch it
all the time, even if the contents haven't changed.

RFC because I can't wrap my head around why this wasn't done ages ago.
If I'm missing something something obvious, please apply a cluestick. :)

Lightly tested - if I rm one of those two files, it gets rebuilt. If I
insert some whitespace, it gets replaced. If I don't touch it, the datestamp
doesn't change.

--- linux-next/Kbuild.dist	2015-03-03 19:50:45.175673346 -0500
+++ linux-next/Kbuild	2015-03-03 20:03:20.107820199 -0500
@@ -15,7 +15,7 @@
 
 quiet_cmd_offsets = GEN     $@
 define cmd_offsets
-	(set -e; \
+	( (set -e; \
 	 echo "#ifndef $2"; \
 	 echo "#define $2"; \
 	 echo "/*"; \
@@ -26,7 +26,10 @@
 	 echo ""; \
 	 sed -ne $(sed-y) $<; \
 	 echo ""; \
-	 echo "#endif" ) > $@
+	 echo "#endif" ) > $@.tmp; \
+	 if [ ! -f $@ ]; then mv $@.tmp $@; \
+	 elif cmp -s $@ $@.tmp ; then rm $@.tmp; \
+	 else mv -f $@.tmp $@; fi )
 endef
 
 #####



             reply	other threads:[~2015-03-04  1:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04  1:07 Valdis Kletnieks [this message]
2015-03-08 23:08 ` Linus Torvalds
2015-03-11 10:01   ` Michal Marek
2015-03-13  4:59     ` Masahiro Yamada
2015-03-13 10:00       ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15447.1425431256@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=linus@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®