From: Lucas Stach <l.stach@pengutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
patchwork-lst@pengutronix.de, Jason Cooper <jason@lakedaemon.net>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip/irq-imx-gpcv2: add IRQCHIP_DECLARE for i.MX8MQ compatible
Date: Mon, 17 Dec 2018 16:51:21 +0100 [thread overview]
Message-ID: <1545061881.5874.10.camel@pengutronix.de> (raw)
In-Reply-To: <20181214121528.5534-1-l.stach@pengutronix.de>
Hi Marc,
Am Freitag, den 14.12.2018, 13:15 +0100 schrieb Lucas Stach:
> The GPC node on i.MX8MQ can not claim to be compatible with the i.MX7D
> GPC, as the power gating part has some significant differences. Thus we
> can not rely on the irqchip being probed with the old compatible.
>
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/irqchip/irq-imx-gpcv2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 17a2dad2d4c2..68b9cca24044 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -289,4 +289,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
> > return 0;
> }
>
> -IRQCHIP_DECLARE(imx_gpcv2, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
> +IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init);
> +IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init);
It would be nice if we could get this into 4.21, as this is the last
missing bit preventing me from pushing forward on the patches
describing the i.MX8MQ IRQ hierarchy properly for the next cycle.
Regards,
Lucas
next prev parent reply other threads:[~2018-12-17 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 12:15 Lucas Stach
2018-12-17 15:51 ` Lucas Stach [this message]
2018-12-18 12:59 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545061881.5874.10.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=patchwork-lst@pengutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®