From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-acpi@vger.kernel.org,
Vikas Sajjan <vikas.cha.sajjan@hpe.com>, Sunil <sunil.vl@hpe.com>,
Prashanth Prakash <pprakash@codeaurora.org>,
Al Stone <al.stone@linaro.org>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)
Date: Sat, 25 Jun 2016 00:47:41 +0200 [thread overview]
Message-ID: <15462807.mkANpcI9rV@vostro.rjw.lan> (raw)
In-Reply-To: <576DA047.7080808@linaro.org>
On Friday, June 24, 2016 11:04:07 PM Daniel Lezcano wrote:
> On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote:
> > Hi Sudeep,
> >
> > On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote:
> >> This patch adds appropriate callbacks to support ACPI Low Power Idle
> >> (LPI) on ARM64.
> >>
> >> Now that arm_enter_idle_state is exactly same in both generic ARM{32,64}
> >> CPUIdle driver and ARM64 backend for ACPI processor idle driver, we can
> >> unify it and move to cpuidle-arm.h header.
> >>
> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >> Cc: Mark Rutland <mark.rutland@arm.com>
> >> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >> ---
> >> arch/arm64/kernel/cpuidle.c | 17 +++++++++++++
> >> drivers/cpuidle/cpuidle-arm.c | 23 ++----------------
> >> drivers/firmware/psci.c | 56 +++++++++++++++++++++++++++++++++++++++++++
> >> include/linux/cpuidle-arm.h | 30 +++++++++++++++++++++++
> >> 4 files changed, 105 insertions(+), 21 deletions(-)
> >> create mode 100644 include/linux/cpuidle-arm.h
> >
> > This patch seems fine by me, it would be good if Daniel can have
> > a look too.
> >
> > Some minor comments below.
> >
> > [...]
> >
> >> diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c
> >> index 03e04582791c..c6caa863d156 100644
> >> --- a/drivers/firmware/psci.c
> >> +++ b/drivers/firmware/psci.c
> >> @@ -13,6 +13,7 @@
> >>
> >> #define pr_fmt(fmt) "psci: " fmt
> >>
> >> +#include <linux/acpi.h>
> >> #include <linux/arm-smccc.h>
> >> #include <linux/cpuidle.h>
> >> #include <linux/errno.h>
> >> @@ -310,11 +311,66 @@ static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu)
> >> return ret;
> >> }
> >>
> >> +#ifdef CONFIG_ACPI
> >> +#include <acpi/processor.h>
> >> +
> >> +static int __maybe_unused psci_acpi_cpu_init_idle(unsigned int cpu)
> >> +{
> >> + int i, count;
> >> + u32 *psci_states;
> >> + struct acpi_processor *pr;
> >> + struct acpi_lpi_state *lpi;
> >> +
> >> + pr = per_cpu(processors, cpu);
> >> + if (unlikely(!pr || !pr->flags.has_lpi))
> >> + return -EINVAL;
> >> +
> >> + /*
> >> + * If the PSCI cpu_suspend function hook has not been initialized
> >> + * idle states must not be enabled, so bail out
> >> + */
> >> + if (!psci_ops.cpu_suspend)
> >> + return -EOPNOTSUPP;
> >> +
> >> + count = pr->power.count - 1;
> >> + if (count <= 0)
> >> + return -ENODEV;
> >> +
> >> + psci_states = kcalloc(count, sizeof(*psci_states), GFP_KERNEL);
> >> + if (!psci_states)
> >> + return -ENOMEM;
> >> +
> >> + for (i = 0; i < count; i++) {
> >> + u32 state;
> >> +
> >> + lpi = &pr->power.lpi_states[i + 1];
> >> + state = lpi->address & 0xFFFFFFFF;
>
> Why is needed to mask 'address' ?
>
> >> + if (!psci_power_state_is_valid(state)) {
> >> + pr_warn("Invalid PSCI power state %#x\n", state);
> >> + kfree(psci_states);
> >> + return -EINVAL;
> >> + }
> >> + psci_states[i] = state;
> >> + }
> >> + /* Idle states parsed correctly, initialize per-cpu pointer */
> >> + per_cpu(psci_power_state, cpu) = psci_states;
> >> + return 0;
> >
> > Most of the code in this function is FW independent, it would be nice
> > to factor it out and add the respective ACPI/DT helper functions to
> > retrieve idle states count and parameters, we can update it later
> > anyway it is fine by me to leave it as it is.
> >
> >> +}
> >> +#else
> >> +static int __maybe_unused psci_acpi_cpu_init_idle(unsigned int cpu)
> >> +{
> >> + return -EINVAL;
> >> +}
> >> +#endif
> >> +
> >> int psci_cpu_init_idle(unsigned int cpu)
> >> {
> >> struct device_node *cpu_node;
> >> int ret;
> >>
> >> + if (!acpi_disabled)
> >> + return psci_acpi_cpu_init_idle(cpu);
>
> Is it possible the case where there is information in both the DT and in
> ACPI ?
No, it isn't.
It is either-or, never both at the same time.
Thanks,
Rafael
next prev parent reply other threads:[~2016-06-24 22:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 14:48 [PATCH v6 0/5] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla
2016-06-14 14:48 ` [PATCH v6 1/5] ACPI / processor_idle: introduce ACPI_PROCESSOR_CSTATE Sudeep Holla
2016-06-14 14:48 ` [PATCH v6 2/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states Sudeep Holla
2016-06-14 16:47 ` Sudeep Holla
2016-06-14 16:54 ` [PATCH v6 2/5][UPDATED] " Sudeep Holla
2016-06-14 14:48 ` [PATCH v6 3/5] arm64: cpuidle: drop __init section marker to arm_cpuidle_init Sudeep Holla
2016-06-22 16:09 ` Lorenzo Pieralisi
2016-06-14 14:48 ` [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI) Sudeep Holla
2016-06-22 14:17 ` Lorenzo Pieralisi
2016-06-24 21:04 ` Daniel Lezcano
2016-06-24 22:47 ` Rafael J. Wysocki [this message]
2016-06-25 8:05 ` Daniel Lezcano
2016-06-27 9:50 ` Sudeep Holla
2016-06-27 16:29 ` Daniel Lezcano
2016-06-27 17:07 ` Sudeep Holla
2016-06-27 17:58 ` Sudeep Holla
2016-06-14 14:48 ` [PATCH v6 5/5] ACPI : enable ACPI_PROCESSOR_IDLE on ARM64 Sudeep Holla
2016-06-27 14:33 ` Daniel Lezcano
2016-06-27 15:03 ` Sudeep Holla
2016-06-27 15:05 ` Daniel Lezcano
2016-06-27 15:06 ` Sudeep Holla
2016-06-27 15:08 ` Daniel Lezcano
2016-06-27 15:11 ` Sudeep Holla
2016-06-27 15:12 ` Daniel Lezcano
2016-06-22 17:45 ` [PATCH v6 0/5] ACPI / processor_idle: Add ACPI v6.0 LPI support Sudeep Holla
2016-06-23 0:42 ` Rafael J. Wysocki
2016-06-25 0:23 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15462807.mkANpcI9rV@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=al.stone@linaro.org \
--cc=ashwin.chaugule@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=pprakash@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=sunil.vl@hpe.com \
--cc=vikas.cha.sajjan@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®