From: Scott Wood <swood@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Scott Wood <swood@redhat.com>
Subject: [PATCH RT] rtmutex: Flush block plug on __down_read()
Date: Fri, 4 Jan 2019 15:33:21 -0500 [thread overview]
Message-ID: <1546634001-4450-1-git-send-email-swood@redhat.com> (raw)
__down_read() bypasses the rtmutex frontend to call
rt_mutex_slowlock_locked() directly, and thus it needs to call
blk_schedule_flush_flug() itself.
Signed-off-by: Scott Wood <swood@redhat.com>
---
kernel/locking/rwsem-rt.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/kernel/locking/rwsem-rt.c b/kernel/locking/rwsem-rt.c
index 660e22caf709..f73cd4eda5cd 100644
--- a/kernel/locking/rwsem-rt.c
+++ b/kernel/locking/rwsem-rt.c
@@ -1,5 +1,6 @@
/*
*/
+#include <linux/blkdev.h>
#include <linux/rwsem.h>
#include <linux/sched/debug.h>
#include <linux/sched/signal.h>
@@ -88,6 +89,15 @@ static int __sched __down_read_common(struct rw_semaphore *sem, int state)
if (__down_read_trylock(sem))
return 0;
+ /*
+ * If sem->rtmutex blocks, the function sched_submit_work will not
+ * call blk_schedule_flush_plug (because tsk_is_pi_blocked would be
+ * true). We must call blk_schedule_flush_plug here; if we don't
+ * call it, an I/O deadlock may occur.
+ */
+ if (unlikely(blk_needs_flush_plug(current)))
+ blk_schedule_flush_plug(current);
+
might_sleep();
raw_spin_lock_irq(&m->wait_lock);
/*
--
1.8.3.1
next reply other threads:[~2019-01-04 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 20:33 Scott Wood [this message]
2019-01-07 16:50 ` Sebastian Andrzej Siewior
2019-01-08 19:19 ` Scott Wood
2019-01-09 8:31 ` Sebastian Andrzej Siewior
2019-01-09 9:48 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546634001-4450-1-git-send-email-swood@redhat.com \
--to=swood@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®