From: Scott Wood <swood@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-rt-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
stable-rt@vger.kernel.org
Subject: Re: [PATCH RT] x86/mm/pat: disable preemption __split_large_page() after spin_lock()
Date: Tue, 08 Jan 2019 18:39:15 -0600 [thread overview]
Message-ID: <1546994355.3632.15.camel@redhat.com> (raw)
In-Reply-To: <20181213164430.mggilzfjgr5retz6@linutronix.de>
On Thu, 2018-12-13 at 17:44 +0100, Sebastian Andrzej Siewior wrote:
> Commit "x86/mm/pat: Disable preemption around __flush_tlb_all()" added a
> warning if __flush_tlb_all() is invoked in preemptible context. On !RT
> the warning does not trigger because a spin lock is acquired which
> disables preemption. On RT the spin lock does not disable preemption and
> so the warning is seen.
>
> Disable preemption to avoid the warning in __flush_tlb_all().
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
FWIW, that __flush_tlb_all() can probably just be removed. It was added as
a partial workaround for an erratum, but since it didn't completely solve
the problem, hugepages were disabled on the affected chips in commit
7a0fc404ae66377 ("x86: Disable large pages on CPUs with Atom erratum
AAE44"). I was going to send a (non-RT) patch removing the flush but in
4.20 commit c0a759abf5a68 ("x86/mm/cpa: Move flush_tlb_all()") reworked the
code to make it moot.
-Scott
next prev parent reply other threads:[~2019-01-09 0:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 16:44 Sebastian Andrzej Siewior
2018-12-13 17:59 ` Steven Rostedt
2018-12-13 18:27 ` Sebastian Andrzej Siewior
2018-12-13 20:37 ` [PATCH RT v2] " Sebastian Andrzej Siewior
2019-01-09 0:39 ` Scott Wood [this message]
2019-01-09 8:48 ` [PATCH RT] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546994355.3632.15.camel@redhat.com \
--to=swood@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable-rt@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome