From: Oliver Neukum <oneukum@suse.com>
To: Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu
Cc: brajeswar.linux@gmail.com, jrdr.linux@gmail.com,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] drivers/usb/storage/jumpshot.c: Remove duplicate header
Date: Thu, 10 Jan 2019 08:41:08 +0100 [thread overview]
Message-ID: <1547106068.7403.17.camel@suse.com> (raw)
In-Reply-To: <5c36f533.1c69fb81.253c8.2646@mx.google.com>
On Do, 2019-01-10 at 13:03 +0530, Sabyasachi Gupta wrote:
> Remove unusual_jumpshot.h which is included more than once.
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> drivers/usb/storage/jumpshot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
> index 917f170..06e46c6 100644
> --- a/drivers/usb/storage/jumpshot.c
> +++ b/drivers/usb/storage/jumpshot.c
> @@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
> }
>
> static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
> -# include "unusual_jumpshot.h"
> { } /* Terminating entry */
> };
>
NACK.
It is included twice because the same device needs to be specified
and is quirky. You are breaking the driver.
Regards
Oliver
prev parent reply other threads:[~2019-01-10 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 7:33 Sabyasachi Gupta
2019-01-10 7:41 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547106068.7403.17.camel@suse.com \
--to=oneukum@suse.com \
--cc=brajeswar.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sabyasachi.linux@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome