From: "S, Shirish" <Shirish.S@amd.com>
To: --cc=Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
"maintainer : X86 ARCHITECTURE" <x86@kernel.org>,
Tony Luck <tony.luck@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"open list : X86 ARCHITECTURE" <linux-kernel@vger.kernel.org>,
"S, Shirish" <Shirish.S@amd.com>
Subject: [PATCH 1/3] x86/mce/amd: apply MC4_MISC thresholding to all models of family 15
Date: Thu, 10 Jan 2019 07:54:40 +0000 [thread overview]
Message-ID: <1547106849-3476-2-git-send-email-shirish.s@amd.com> (raw)
In-Reply-To: <1547106849-3476-1-git-send-email-shirish.s@amd.com>
Its evident from various forums and logs that MC4_MISC thresholding is not
supported for the family 15 processors, hence skip the x86_model check
while applying quirk.
Changelog[v2]:
- reword commit message to adhere to coding standards
- remove check of model range
Signed-off-by: Shirish S <shirish.s@amd.com>
---
arch/x86/kernel/cpu/mce/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 672c722..d0c5416 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -1612,11 +1612,10 @@ static int __mcheck_cpu_apply_quirks(struct cpuinfo_x86 *c)
mce_flags.overflow_recov = 1;
/*
- * Turn off MC4_MISC thresholding banks on those models since
+ * Turn off MC4_MISC thresholding banks on all models since
* they're not supported there.
*/
- if (c->x86 == 0x15 &&
- (c->x86_model >= 0x10 && c->x86_model <= 0x1f)) {
+ if (c->x86 == 0x15) {
int i;
u64 hwcr;
bool need_toggle;
--
2.7.4
next prev parent reply other threads:[~2019-01-10 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 7:54 [PATCH 0/3] x86/mce/amd: apply missing quirks to family 15 models (v2) S, Shirish
2019-01-10 7:54 ` S, Shirish [this message]
2019-01-16 19:30 ` [tip:ras/core] x86/MCE/AMD: Turn off MC4_MISC thresholding on all family 0x15 models tip-bot for Shirish S
2019-01-10 7:54 ` [PATCH 2/3] x86/mce/amd: carve out MC4_MISC thresholding quirk S, Shirish
2019-01-10 7:54 ` [PATCH 3/3] x86/mce/amd: apply MC4_MISC thresholding quirk in resume path S, Shirish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547106849-3476-2-git-send-email-shirish.s@amd.com \
--to=shirish.s@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®