From: Paul Mackerras <paulus@samba.org>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: lkml <linux-kernel@vger.kernel.org>,
benh@kernel.crashing.org, trini@kernel.crashing.org
Subject: Re: Linux 2.4.18-rc2
Date: Tue, 19 Feb 2002 12:43:06 +1100 (EST) [thread overview]
Message-ID: <15473.44458.756040.513997@argo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0202181815480.25479-100000@freak.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0202181815480.25479-100000@freak.distro.conectiva>
Marcelo Tosatti writes:
> Well hopefully have a 2.4.18 pretty soon..
The fix to drivers/sound/dmasound/tas3001c.c, to export
tumbler_enter_sleep and tumbler_leave_sleep, is still not included.
Could we have that one in before 2.4.18 final is released, please?
Otherwise compiling a kernel for a powermac will fail.
Regards,
Paul.
diff -urN linux-2.4.18-rc2/drivers/sound/dmasound/tas3001c.c pmac/drivers/sound/dmasound/tas3001c.c
--- linux-2.4.18-rc2/drivers/sound/dmasound/tas3001c.c Tue Feb 19 12:37:37 2002
+++ pmac/drivers/sound/dmasound/tas3001c.c Thu Jan 24 15:12:10 2002
@@ -67,8 +67,8 @@
static struct i2c_client * tumbler_client = NULL;
-static int tumbler_enter_sleep(void);
-static int tumbler_leave_sleep(void);
+int tumbler_enter_sleep(void);
+int tumbler_leave_sleep(void);
static int tas_attach_adapter(struct i2c_adapter *adapter);
static int tas_detect_client(struct i2c_adapter *adapter, int address);
@@ -298,7 +298,7 @@
return 0;
}
-static int
+int
tumbler_leave_sleep(void)
{
/* Stub for now, but I have the details on low-power mode */
@@ -308,7 +308,7 @@
return 0;
}
-static int
+int
tumbler_enter_sleep(void)
{
/* Stub for now, but I have the details on low-power mode */
next prev parent reply other threads:[~2002-02-19 1:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-18 20:16 Marcelo Tosatti
2002-02-18 21:52 ` Rik van Riel
2002-02-19 1:43 ` Paul Mackerras [this message]
2002-02-21 8:29 ` Adrian Bunk
2002-02-21 9:28 ` Jeff Garzik
2002-02-21 12:43 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15473.44458.756040.513997@argo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®