From: Andrew Murray <andrew.murray@arm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, Grant Likely <Grant.Likely@arm.com>,
Steven Price <Steven.Price@arm.com>,
Dave P Martin <Dave.Martin@arm.com>
Subject: [Linux-eng] [RFC 0/3] Abstract empty functions with STUB_UNLESS macro
Date: Fri, 18 Jan 2019 16:00:27 +0000 [thread overview]
Message-ID: <1547827230-55132-1-git-send-email-andrew.murray@arm.com> (raw)
A common pattern found in header files is a function declaration dependent
on a CONFIG_ option being enabled, followed by an empty function for when
that option isn't enabled. This boilerplate code can often take up a lot
of space and impact code readability.
This series introduces a STUB_UNLESS macro that simplifies header files as
follows:
STUB_UNLESS(CONFIG_FOO, [body], prototype)
This evaluates to 'prototype' prepended with 'extern' if CONFIG_FOO is set
to 'y'. Otherwise it will evaluate to 'prototype' prepended with 'static
inline' followed by an empty function body. Where optional argument 'body'
is present then 'body' will be used as the function body, intended to allow
simple return statements. Using the macro results in hunks such as this:
-#ifdef CONFIG_HAVE_HW_BREAKPOINT
-extern void hw_breakpoint_thread_switch(struct task_struct *next);
-extern void ptrace_hw_copy_thread(struct task_struct *task);
-#else
-static inline void hw_breakpoint_thread_switch(struct task_struct *next)
-{
-}
-static inline void ptrace_hw_copy_thread(struct task_struct *task)
-{
-}
-#endif
+STUB_UNLESS(CONFIG_HAVE_HW_BREAKPOINT,
+void hw_breakpoint_thread_switch(struct task_struct *next));
+
+STUB_UNLESS(CONFIG_HAVE_HW_BREAKPOINT,
+void ptrace_hw_copy_thread(struct task_struct *task));
This may or may not be considered as more desirable than the status quo.
This series updates arm64 and perf to use the macro as an example.
Andrew Murray (3):
kconfig.h: abstract empty functions with STUB_UNLESS macro
cpufreq: update headers to use STUB_UNLESS macro
arm64: update headers to use STUB_UNLESS macro
arch/arm64/include/asm/acpi.h | 38 +++++++++-------------
arch/arm64/include/asm/alternative.h | 6 +---
arch/arm64/include/asm/cpufeature.h | 6 +---
arch/arm64/include/asm/cpuidle.h | 18 +++--------
arch/arm64/include/asm/debug-monitors.h | 10 ++----
arch/arm64/include/asm/fpsimd.h | 57 +++++++++++++--------------------
arch/arm64/include/asm/hw_breakpoint.h | 16 +++------
arch/arm64/include/asm/kasan.h | 9 ++----
arch/arm64/include/asm/numa.h | 19 ++++-------
arch/arm64/include/asm/ptdump.h | 13 +++-----
arch/arm64/include/asm/signal32.h | 29 +++++------------
include/linux/cpufreq.h | 21 ++++--------
include/linux/kconfig.h | 31 ++++++++++++++++++
13 files changed, 110 insertions(+), 163 deletions(-)
--
2.7.4
next reply other threads:[~2019-01-18 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 16:00 Andrew Murray [this message]
2019-01-18 16:00 ` [PATCH 1/3] kconfig.h: abstract " Andrew Murray
2019-01-18 16:27 ` Steven Price
2019-01-18 16:00 ` [PATCH 2/3] cpufreq: update headers to use " Andrew Murray
2019-01-18 16:29 ` Steven Price
2019-01-18 16:00 ` [PATCH 3/3] arm64: " Andrew Murray
2019-01-18 16:46 ` Steven Price
2019-01-18 16:37 ` [Linux-eng] [RFC 0/3] Abstract empty functions with " Russell King - ARM Linux admin
2019-01-18 16:44 ` Dave Martin
2019-01-18 17:01 ` Andrew Murray
2019-01-19 3:44 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547827230-55132-1-git-send-email-andrew.murray@arm.com \
--to=andrew.murray@arm.com \
--cc=Dave.Martin@arm.com \
--cc=Grant.Likely@arm.com \
--cc=Steven.Price@arm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®