From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AAFDC282C0 for ; Wed, 23 Jan 2019 16:50:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54C082085A for ; Wed, 23 Jan 2019 16:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbfAWQuf (ORCPT ); Wed, 23 Jan 2019 11:50:35 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:44029 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfAWQuf (ORCPT ); Wed, 23 Jan 2019 11:50:35 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gmLjR-000789-4F; Wed, 23 Jan 2019 17:50:29 +0100 Message-ID: <1548262227.28802.7.camel@pengutronix.de> Subject: Re: [PATCH v3 5/5] imx8mq.dtsi: add the sdma nodes From: Lucas Stach To: "Angus Ainslie (Purism)" Cc: angus.ainslie@puri.sm, Vinod Koul , dmaengine@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Baluta Date: Wed, 23 Jan 2019 17:50:27 +0100 In-Reply-To: <20190123152310.11680-6-angus@akkea.ca> References: <20190120023150.17138-1-angus@akkea.ca> <20190123152310.11680-1-angus@akkea.ca> <20190123152310.11680-6-angus@akkea.ca> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, den 23.01.2019, 08:23 -0700 schrieb Angus Ainslie (Purism): > Add the sdma nodes to the base devicetree for the imx8mq > > > Signed-off-by: Angus Ainslie (Purism) > --- >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 31 +++++++++++++++++++++++ >  1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index c0402375e7c1..4397992fd021 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -336,6 +336,19 @@ > >   clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>; > >   status = "disabled"; > >   }; > + > > > + sdma2: sdma@302c0000 { > > + compatible = "fsl,imx8mq-sdma", "fsl,imx7d-sdma"; > > + reg = <0x302c0000 0x10000>; > > + interrupts = ; > > + clocks = <&clk IMX8MQ_CLK_SDMA2_ROOT>, > > + <&clk IMX8MQ_CLK_SDMA2_ROOT>; > > + clock-names = "ipg", "ahb"; > > + #dma-cells = <3>; > > + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; > + fsl,ratio-1-1; Property does not exist anymore. > + status = "disabled"; SoC peripherals that have no outside connection and thus don't depend on any board level configuration should always be enabled. Please drop this status property. > + }; > >   }; >   > >   bus@30400000 { /* AIPS2 */ > @@ -370,6 +383,8 @@ > >   clocks = <&clk IMX8MQ_CLK_UART3_ROOT>, > >            <&clk IMX8MQ_CLK_UART3_ROOT>; > >   clock-names = "ipg", "per"; > > + dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>; > > + dma-names = "rx", "tx"; > >   status = "disabled"; > >   }; >   > @@ -381,6 +396,8 @@ > >   clocks = <&clk IMX8MQ_CLK_UART2_ROOT>, > >            <&clk IMX8MQ_CLK_UART2_ROOT>; > >   clock-names = "ipg", "per"; > > + dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>; > > + dma-names = "rx", "tx"; > >   status = "disabled"; > >   }; >   > @@ -432,6 +449,8 @@ > >   clocks = <&clk IMX8MQ_CLK_UART4_ROOT>, > >            <&clk IMX8MQ_CLK_UART4_ROOT>; > >   clock-names = "ipg", "per"; > > + dmas = <&sdma1 28 4 0>, <&sdma1 29 4 0>; > > + dma-names = "rx", "tx"; > >   status = "disabled"; > >   }; >   > @@ -465,6 +484,18 @@ > >   status = "disabled"; > >   }; >   > > > + sdma1: sdma@30bd0000 { > > + compatible = "fsl,imx8mq-sdma", "fsl,imx7d-sdma"; > > + reg = <0x30bd0000 0x10000>; > > + interrupts = ; > > + clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>, > > + <&clk IMX8MQ_CLK_AHB>; > > + clock-names = "ipg", "ahb"; > > + #dma-cells = <3>; > > + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; > + status = "disabled"; Same comment as above, this node should be enabled by default. Regards, Lucas > + }; > + > > >   fec1: ethernet@30be0000 { > >   compatible = "fsl,imx8mq-fec", "fsl,imx6sx-fec"; > >   reg = <0x30be0000 0x10000>;