From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 838DFC282C0 for ; Fri, 25 Jan 2019 10:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 533C8218D2 for ; Fri, 25 Jan 2019 10:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbfAYKqL (ORCPT ); Fri, 25 Jan 2019 05:46:11 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:58771 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725909AbfAYKqL (ORCPT ); Fri, 25 Jan 2019 05:46:11 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gmyzy-0002eL-5v; Fri, 25 Jan 2019 11:46:10 +0100 Message-ID: <1548413169.28802.43.camel@pengutronix.de> Subject: Re: [PATCH 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support From: Lucas Stach To: Aisheng Dong , "linux-kernel@vger.kernel.org" Cc: "linux-arm-kernel@lists.infradead.org" , "shawnguo@kernel.org" , dl-linux-imx , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "tglx@linutronix.de" , Marc Zyngier Date: Fri, 25 Jan 2019 11:46:09 +0100 In-Reply-To: <1547797668-30342-3-git-send-email-aisheng.dong@nxp.com> References: <1547797668-30342-1-git-send-email-aisheng.dong@nxp.com> <1547797668-30342-3-git-send-email-aisheng.dong@nxp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > One irqsteer channel can support up to 8 output interrupts. > > > Cc: Marc Zyngier > > Cc: Rob Herring > > Cc: Lucas Stach > > Cc: Shawn Guo > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng > --- >  .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt        | 5 +++-- >  1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > index eaabcda..beeed4a 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > @@ -6,8 +6,9 @@ Required properties: > >   - "fsl,imx8m-irqsteer" > >   - "fsl,imx-irqsteer" >  - reg: Physical base address and size of registers. > -- interrupts: Should contain the parent interrupt line used to multiplex the > -  input interrupts. > +- interrupts: Should contain the up to 8 parent interrupt lines used to > +  multiplex the input interrupts. They should be sepcified seqencially > +  from output 0 to 7. NOTE at least one output interrupt has to be specified. I don't think the note clarifies anything. Given that the thing is a irq multiplexer I don't think anyone expects that you could get away with no output irq. If anything this should specify that it's always groups of (up to) 64 input irqs being muxed onto a single output irq. Regards, Lucas